1361746 - [Windows] "Legacy" badge not aligned with the add-on name in details tab

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P5)

Description

[Vasilica Tamas, QA [:vtamas]]

Attachment: 2017-05-03_1817.png

[Note]
This is a follow-up bug for Bug 1354682

[Affected versions]:
Firefox 55.0a1 (2017-05-03)

[Affected platforms]:
Windows 10 64-bit


[Steps to reproduce]:
1.Launch Firefox with a clean profile.
2.Install a legacy add-on.
3.Navigate to Add-ons Manager -> Extensions.
4.Open the legacy add-on details tab by clicking on “More” link.

[Expected Results]:
“Legacy” badge is properly displayed in add-on details tab.


[Actual Results]:
“Legacy” badge is not aligned with the add-on name in details tab. 
See attached screenshot.

Comment 1

[:shell escalante]

Hi Mark,

If this is going to take 15 minutes or less... then please fix.  Not worth any more of your time... just makes it look bad though.

Comment 2

[Mark Striemer [:mstriemer]]

Attachment: Bug 1361746 - Align legacy badge on Windows in about:addons details

Review commit: https://reviewboard.mozilla.org/r/141104/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141104/

Comment 3

[Mark Striemer [:mstriemer]]

Comment on attachment 8869493 [details]
Bug 1361746 - Align legacy badge on Windows in about:addons details

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141104/diff/1-2/

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8869493 [details]
Bug 1361746 - Align legacy badge on Windows in about:addons details

https://reviewboard.mozilla.org/r/141104/#review144636

Is there some way to unify this with http://searchfox.org/mozilla-central/rev/24c443a440104dabd9447608bd41b8766e8fc2f5/toolkit/themes/shared/extensions/extensions.inc.css#475-477 ?

Comment 5

[Mark Striemer [:mstriemer]]

Comment on attachment 8869493 [details]
Bug 1361746 - Align legacy badge on Windows in about:addons details

https://reviewboard.mozilla.org/r/141104/#review144636

The math seems to work out that `0.78rem` is the correct value, but the baseline of the Windows font seems to be different which is causing it to appear higher. I tried wrapping the badge in a vbox and vertically centring it but that places it in the same spot as with the original `margin-top: 0.78rem`.

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: updated.png

Comment 7

[Mark Striemer [:mstriemer]]

Comment on attachment 8869493 [details]
Bug 1361746 - Align legacy badge on Windows in about:addons details

This is just a small Windows only CSS change to deal the text not being vertically centred in its container causing the badge to look misaligned when it is centred.

As mentioned above the math checked out for the old value but it didn't look right so this adds some extra offset as a magic number unfortunately.

Comment 8

[Robert Helmer [:rhelmer]]

Comment on attachment 8869493 [details]
Bug 1361746 - Align legacy badge on Windows in about:addons details

https://reviewboard.mozilla.org/r/141104/#review146122

ugh, CSS.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b67475611dd
Align legacy badge on Windows in about:addons details r=rhelmer

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3b67475611dd

Comment 11

[Tanvir Rahman]

I have reproduced this Bug with Nightly 55.0a1 (2017-05-03) on Windows 10, 64 Bit!

The bug's fix is now verified on latest Beta 55.0b8

Build ID 	20170710085521
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Comment 12

[Vasilica Tamas, QA [:vtamas]]

Thanks Tanvir for verifying this bug! Based on Comment 11 I am marking this issue as Verified.