Closed Bug 1361807 Opened 4 years ago Closed 4 years ago

about:home renders at 0,0 in the window instead of below the toolbar

Categories

(Core :: Graphics: WebRender, enhancement, P3)

Other Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

I made an error in bug 1360246, in the RefLayer implementation. The RefLayer doesn't push a stacking context, so we need to transform the bounds by the layer's transform before we can take it as relative to the enclosing stacking context. We do this for the WebRenderDisplayItemLayer and WebRenderTextLayer already, and used to do for WebRenderRefLayer, but I accidentally removed it and didn't notice. The reftests don't catch this either because they don't create iframes, I guess.
Actually even reftests with iframes wouldn't catch this, since it has to be a subwindow with a separate layer tree. I have a patch coming soon.
Comment on attachment 8864270 [details]
Bug 1361807 - Use the transformed bounds for WebRenderRefLayer, as it doesn't push a stacking context.

https://reviewboard.mozilla.org/r/135904/#review139196
Attachment #8864270 - Flags: review?(nical.bugzilla) → review+
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/93f41e15c9a7
Use the transformed bounds for WebRenderRefLayer, as it doesn't push a stacking context. r=nical
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.