1361807 - about:home renders at 0,0 in the window instead of below the toolbar

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

I made an error in bug 1360246, in the RefLayer implementation. The RefLayer doesn't push a stacking context, so we need to transform the bounds by the layer's transform before we can take it as relative to the enclosing stacking context. We do this for the WebRenderDisplayItemLayer and WebRenderTextLayer already, and used to do for WebRenderRefLayer, but I accidentally removed it and didn't notice. The reftests don't catch this either because they don't create iframes, I guess.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Actually even reftests with iframes wouldn't catch this, since it has to be a subwindow with a separate layer tree. I have a patch coming soon.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1361807 - Use the transformed bounds for WebRenderRefLayer, as it doesn't push a stacking context.

Review commit: https://reviewboard.mozilla.org/r/135904/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/135904/

Comment 3

[Nicolas Silva [:nical]]

Comment on attachment 8864270 [details]
Bug 1361807 - Use the transformed bounds for WebRenderRefLayer, as it doesn't push a stacking context.

https://reviewboard.mozilla.org/r/135904/#review139196

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/93f41e15c9a7
Use the transformed bounds for WebRenderRefLayer, as it doesn't push a stacking context. r=nical

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/93f41e15c9a7