Closed Bug 1361849 Opened 3 years ago Closed 3 years ago

TEST-UNEXPECTED-ERROR | test_fallback_update.py TestFallbackUpdate.test_update | TypeError: __init__() takes exactly 6 arguments (2 given)

Categories

(Testing :: Marionette, defect)

Version 3
defect
Not set

Tracking

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: whimboo, Assigned: whimboo)

References

Details

(Keywords: intermittent-failure, pi-marionette-firefox-puppeteer, regression)

Attachments

(1 file)

aus5.mozilla.org had an outage today and as such I was able to detect a regression in Puppeteer for software updates, when we are trying to falsely re-raise an HTTPError:

  File "/usr/local/Cellar/python/2.7.12_2/Frameworks/Python.framework/Versions/2.7/lib/python2.7/urllib2.py", line 556, in http_error_default
    raise HTTPError(req.get_full_url(), code, msg, hdrs, fp)

It's a regression from my changes on bug 1290850.
The test failure with the patch applied will look like:

TEST-UNEXPECTED-ERROR | test_fallback_update.py TestFallbackUpdate.test_update | Exception: Failed to retrieve update snippet: HTTP Error 500: INTERNAL SERVER ERROR
Comment on attachment 8864306 [details]
Bug 1361849 - Fix handling of HTTPError when the update snippet cannot be retrieved.

https://reviewboard.mozilla.org/r/135928/#review139032
Attachment #8864306 - Flags: review?(mjzffr) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d401cd6d2fd0
Fix handling of HTTPError when the update snippet cannot be retrieved. r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/d401cd6d2fd0
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
test-only patch which fixes a regression. Please uplift to beta. Thanks.
Whiteboard: [checkin-needed-beta]
You need to log in before you can comment on or make changes to this bug.