Closed
Bug 1361893
Opened 7 years ago
Closed 7 years ago
remove two unnecessary mutexes and a cast from SSLServerCertVerification.cpp
Categories
(Core :: Security: PSM, enhancement, P1)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: keeler, Assigned: keeler)
Details
(Whiteboard: [psm-assigned])
Attachments
(1 file)
gSSLVerificationPK11Mutex isn't used at all - it can be removed gSSLVerificationTelemetryMutex is unnecessary because telemetry has its own lock: https://dxr.mozilla.org/mozilla-central/rev/a748acbebbde373a88868dc02910fb2bc5e6a023/toolkit/components/telemetry/TelemetryHistogram.cpp#1135 https://dxr.mozilla.org/mozilla-central/rev/a748acbebbde373a88868dc02910fb2bc5e6a023/toolkit/components/telemetry/TelemetryHistogram.cpp#1984 The nsNSSSocketInfo* cast in SSLServerCertVerificationResult::Run() is unnecessary because mInfoObject is a RefPtr<nsNSSSocketInfo>.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8864342 [details] bug 1361893 - remove two unnecessary mutexes and a cast from SSLServerCertVerification.cpp https://reviewboard.mozilla.org/r/135986/#review139034 Looks good to me.
Attachment #8864342 -
Flags: review?(kmckinley) → review+
|
Assignee | |
Comment 3•7 years ago
|
||
| mozreview-review-reply | ||
Comment on attachment 8864342 [details] bug 1361893 - remove two unnecessary mutexes and a cast from SSLServerCertVerification.cpp https://reviewboard.mozilla.org/r/135986/#review139034 Thanks!
Pushed by dkeeler@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/286184fa338e remove two unnecessary mutexes and a cast from SSLServerCertVerification.cpp r=kmckinley
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/286184fa338e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•