1361907 - Exiting Firefox become much slower

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[atst]

User Agent: Mozilla/5.0 (Windows NT 6.2; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.133 Safari/537.36

Steps to reproduce:

I was on 43.0a.1 to 45.0a.1 the longest time because session restore is in parental process and not content and it was fast with e10.  though restoring over 3000 tabs take about 1.2 minutes, file -> exit takes about 20 sec.

however I tried the new 55.0a.1 and session restore is MUCH faster only 20 seconds, but file -> exit wayyy too slow, takes 3.5 minutes..

reproduce:
open 55.0a.1 and restore lots of tab
click on file -> exit and watch it freeze for 3 minutes


Actual results:

reproduce:
open 55.0a.1 and restore lots of tab
click on file -> exit and watch it freeze for 3 minutes


Expected results:

what should have happen is file -> exit should only take 20-30 seconds just like 45.0a.1.  55.0a.1 had such a fast session restore but the exit part to properly save session killed it, just terribly slow, please fix.

Comment 1

[Will Wang [:WillWang]]

Thanks for your report!

(In reply to unityole from comment #0)
> however I tried the new 55.0a.1 and session restore is MUCH faster only 20
> seconds, but file -> exit wayyy too slow, takes 3.5 minutes..
> 
> reproduce:
> open 55.0a.1 and restore lots of tab
> click on file -> exit and watch it freeze for 3 minutes
My first thought is, could you still reproduce this issue if:
1. disable the session restore feature
or
2. reduce your amount of tab 

If so, I think this is a session restore bug and I'll set this bug to block ss-perf (bug 1330635).

Thanks! :)

Comment 2

[atst]

(In reply to Will Wang [:WillWang] from comment #1)
> Thanks for your report!
> 
> (In reply to unityole from comment #0)
> > however I tried the new 55.0a.1 and session restore is MUCH faster only 20
> > seconds, but file -> exit wayyy too slow, takes 3.5 minutes..
> > 
> > reproduce:
> > open 55.0a.1 and restore lots of tab
> > click on file -> exit and watch it freeze for 3 minutes
> My first thought is, could you still reproduce this issue if:
> 1. disable the session restore feature
> or
> 2. reduce your amount of tab 
> 
> If so, I think this is a session restore bug and I'll set this bug to block
> ss-perf (bug 1330635).
> 
> Thanks! :)

yes less tab means no lag but i mean in comparison to older version which ran fine.  how do i disable session restore feature?

Comment 3

[Will Wang [:WillWang]]

(In reply to unityole from comment #2)
> yes less tab means no lag but i mean in comparison to older version which
> ran fine.  how do i disable session restore feature?

Tools > Options (or open about:preferences page) > When Firefox starts

Comment 4

[:Gijs (he/him)]

Although I would quite like to address this report, I think there is basically not enough data to do anything meaningful here, so closing as incomplete for now. If more data appears about this still being slow (especially after recent session restore improvements in 56+), we should of course revisit.