1361944 - ASSERTION: Shouldn't have a decoder: 'mDecoder == nullptr'

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P1)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/b0e1da2a90ada7e00f265838a3fafd00af33e547/dom/html/HTMLMediaElement.cpp#4584

Hit this assertion while debugging 1361756.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1361944. P1 - add a crash test.

The crash happens when:
1. there are multiple <source> children.
2. decode error happens on the 1st child.

Review commit: https://reviewboard.mozilla.org/r/136086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136086/

Comment 2

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1361944. P2 - be sure to shut down the existing decoder before loading the next source child.

Otherwise we will fail the assertion (!mDecoder, "Shouldn't have a decoder")
in HTMLMediaElement::InitializeDecoderForChannel().

Review commit: https://reviewboard.mozilla.org/r/136088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136088/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8864398 [details]
Bug 1361944. P2 - be sure to shut down the existing decoder before loading the next source child.

https://reviewboard.mozilla.org/r/136088/#review139460

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8864397 [details]
Bug 1361944. P1 - add a crash test.

https://reviewboard.mozilla.org/r/136086/#review139462

Comment 5

[JW Wang [:jwwang] [:jw_wang]]

Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/763cc804a25d
P1 - add a crash test. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/beace30c1073
P2 - be sure to shut down the existing decoder before loading the next source child. r=cpearce

Comment 7

[Bob Clary [:bc] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=beace30c107344274ebfa786ac723247e4ff413c&filter-resultStatus=success&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=running&filter-resultStatus=pending&filter-resultStatus=runnable&filter-resultStatus=coalesced&filter-searchStr=autophone

Caused perma failure

REFTEST TEST-UNEXPECTED-FAIL | http://10.252.73.230:41254/tests/dom/media/test/crashtests/1361944.html | load failed: timed out waiting for reftest-wait to be removed

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

I will disable the test on Android.

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Hi Sheriff,
Can you back out only P1 from the tree? Thanks!

Comment 10

[Iris Hsiao [:ihsiao]]

backed out P1 for causing crashtest perma failure on Android like https://treeherder.mozilla.org/logviewer.html#?job_id=96808742&repo=autoland&lineNumber=3888

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9316a48f009b
Backed out changeset 763cc804a25d for causing crashtest perma failure on Android

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/beace30c1073

Comment 13

[Intermittent Failures Robot]

12 failures in 770 pushes (0.016 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 12

Platform breakdown:
* android-7-1-armv8-api15: 5
* android-6-0-armv8-api15: 4
* android-4-4-armv7-api15: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1361944&startday=2017-05-01&endday=2017-05-07&tree=all