1362142 - Mozharness' platform_name() does not return win64 when running on 64-bit host

Status: RESOLVED FIXED

(Release Engineering :: Applications: MozharnessCore, enhancement)

Description

[Armen [:armenzg]]

The code in particular is this:
https://hg.mozilla.org/mozilla-central/file/0b255199db9d/testing/mozharness/mozharness/base/script.py#l120

We currently use:
> '64' in platform.architecture()[0] # architecture() returns (bits, linkage)

Unfortunately, that is the Python binary byte size.
https://docs.python.org/2/library/platform.html
> platform.architecture(executable=sys.executable, bits='', linkage='')
> 
>    Queries the given executable (defaults to the Python interpreter binary)
>    for various architecture information.
> 
>    Returns a tuple (bits, linkage) which contain information about the bit
>    architecture and the linkage format used for the executable. 

Instead we should be using machine()
> platform.machine()¶
> 
>    Returns the machine type, e.g. 'i386'. An empty string is returned if the
>    value cannot be determined.

My sampling size:
* win10   - AMD64
* win7    - x86
* Linux64 - x86_64
* MacOSX  - x86_64

Comment 1

[Armen [:armenzg]]

Attachment: Bug 1362142 - Mozharness to distinguish Windows archictecture properly.

We currently use:
> '64' in platform.architecture()[0] # architecture() returns (bits, linkage)

Unfortunately, that is the Python binary byte size.
https://docs.python.org/2/library/platform.html
> platform.architecture(executable=sys.executable, bits='', linkage='')
>
>    Queries the given executable (defaults to the Python interpreter binary)
>    for various architecture information.
>
>    Returns a tuple (bits, linkage) which contain information about the bit
>    architecture and the linkage format used for the executable.

Instead we should be using machine()
> platform.machine()
>
>    Returns the machine type, e.g. 'i386'. An empty string is returned if the
>    value cannot be determined.

My sampling size:
* win10   - AMD64
* win7    - x86
* Linux64 - x86_64
* MacOSX  - x86_64

Review commit: https://reviewboard.mozilla.org/r/136286/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136286/

Comment 2

[Aki Sasaki (not active)]

Comment on attachment 8864611 [details]
Bug 1362142 - Mozharness to distinguish Windows archictecture properly.

https://reviewboard.mozilla.org/r/136286/#review139374

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e3aad47ea15
Mozharness to distinguish Windows archictecture properly. r=aki

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4e3aad47ea15