Closed Bug 1362143 Opened 8 years ago Closed 8 years ago

file name field of sound file picker in TB preferences has strange background

Categories

(Thunderbird :: Preferences, defect)

Product:
Thunderbird
Component:
Preferences
Version:
52 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird_esr52 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 52.0
Tracking Flags:
Tracking Status
thunderbird_esr52 --- fixed

People

(Reporter: aceman, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

bug-TB-filefield-no-border.png
52.00 KB, image/png
Details
Bug1362143-TB52.patch
1.79 KB, patch
aceman
: review+
jorgk-bmo
: approval-comm-esr52+
Details | Diff | Splinter Review
The file name field of sound file picker in TB preferences has strange background that seems so cover the whole field including its outline in some parts. See the screenshot. The filename and its grey background "bleed" out of the white field. The file name field was already strange in older GTK3 (like 3.18) but is seems to me this got worse now in 3.22. There are at least 4 of these file fields in Preferences, in General, Chat, Attachments and Calendar tab.
Attached patch Bug1362143-TB52.patch (obsolete) — — Splinter Review
Patch for TB 52. Applies on c-c too for testing. I'll create a patch for toolkit for 55.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8864631 - Flags: review?(acelists)
Comment on attachment 8864631 [details] [diff] [review] Bug1362143-TB52.patch Review of attachment 8864631 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, works perfectly.
Attachment #8864631 - Flags: review?(acelists) → review+
The photo tab in AB has also this filefield and the virtual folder properties dialog too.
Attachment #8864631 - Attachment is obsolete: true
Attachment #8864660 - Flags: review?(acelists)
Comment on attachment 8864660 [details] [diff] [review] Bug1362143-TB52.patch Review of attachment 8864660 [details] [diff] [review]: ----------------------------------------------------------------- Yes, thanks.
Attachment #8864660 - Flags: review?(acelists) → review+
Comment on attachment 8864660 [details] [diff] [review] Bug1362143-TB52.patch [Approval Request Comment] User impact if declined: see screenshot Testing completed (on c-c, etc.): ESR52 only patch Risk to taking this patch (and alternatives if risky): low Jörg, can we land this on ESR52 only? I'll try a different approach for Daily in a new bug which could be too risky for ESR.
Attachment #8864660 - Flags: approval-comm-esr52?
Yes, we can. At least you need to CC me on the bug so I see it. Also, my query only picks up uplift requests for resolved bugs, so I don't see this here. Do those three hunks cover all cases mentioned in comment #0?
Flags: needinfo?(jorgk)
Yes, they cover all.
Attachment #8864660 - Flags: approval-comm-esr52? → approval-comm-esr52+
OK, looks like we do trunk in bug 1362363.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-thunderbird54: affected → ---
status-thunderbird55: affected → ---
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
Version: Trunk → 52 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: