1362157 - "A suitable reviewer has not given a Ship It!" due to bmo/ldap mismatch

Status: RESOLVED FIXED

(MozReview Graveyard :: General, enhancement)

Description

[Steffen Wilberg]

https://reviewboard.mozilla.org/r/134008/diff/3#index_header
says: A suitable reviewer has not given a "Ship It!"
although :mayhemer (Honza Bambas), who is a Necko peer according to
https://wiki.mozilla.org/Modules/Core#Necko
has given his r+

Comment 1

[:glob ✱]

unfortunately the module system has no way for automation to consume, so we rely on a user's scm level to determine if they can grant landing approval.  fixing this is on our radar, but it's unlikely to happen in the short term as it's more than just moving from a freeform wiki page to a database.

also unfortunately there isn't an authoritative source which maps someone's BMO account to their LDAP account.  IT have been working on an identity management system built off mozillians, and it's our hope that one day BMO will be added into that system to provide this linkage.

so mozreview tries to determine a user's ldap account through a few different mechanisms, and sometimes it gets it wrong.
that's what has happened in honza's case - mozreview is looking for him in ldap using his @mozilla address instead of his @firemni one, so it doesn't detect that he has scm level 3.

honza - can you please follow these steps to manually link your BMO and LDAP accounts:
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/install.html#manually-associating-your-ldap-account-with-mozreview

once that happens your reviews will include blessings for landing.

Comment 2

[:glob ✱]

sorry; forgot to NI honza.

Comment 3

[Honza Bambas (:mayhemer)]

I believe I've done so a long ago already.  But I just generated a new API key and made the association once again:


associating LDAP account <my bz addr>@firemni.cz with Bugzilla account <my bz addr>@firemni.cz...
LDAP account successfully associated!

Comment 4

[Honza Bambas (:mayhemer)]

And BTW, r+ on br and autoland used to work in the past, I think.

Comment 5

[:glob ✱]

thanks honza; sorry about the hassle.

everything looks good now, closing.