Closed
Bug 1362160
Opened 8 years ago
Closed 8 years ago
disable file name field of sound file picker in TB preferences when it is not used
Categories
(Thunderbird :: Preferences, defect)
Thunderbird
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: aceman, Assigned: aceman)
Details
(Keywords: polish)
Attachments
(1 file)
|
2.38 KB,
patch
|
Paenglab
:
review+
|
Details | Diff | Splinter Review |
The file name field of sound file picker in TB preferences can be disabled if the sound chosen in is is not meant to be played by the user. The other form elements on the settings page determine if the sound file will ever be used. We already disable the "Browse" button, but miss the filename field.
There are 4 of such fields in the Preferences dialog and 2 of them already disable the field properly (calendar and attachment page). I'll fix the remaining two.
Make the code disable the file name field first and then the accompanying "browse" button gets disabled automatically via the already existing <observes> element.
Attachment #8864624 -
Flags: review?(richard.marti)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8864624 [details] [diff] [review]
1362160.patch
Thanks, works perfectly.
Attachment #8864624 -
Flags: review?(richard.marti) → review+
Thanks.
|
||
Comment 4•8 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•