Closed Bug 1362191 Opened 4 years ago Closed 4 years ago

Remove GeckoInterface.doRestart

Categories

(GeckoView :: General, enhancement)

50 Branch
Unspecified
Android
enhancement
Not set
normal

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(4 files)

No description provided.
In the GeckoBundle data for the "Gecko:Exited" event, indicate whether
we should restart or not through the "restart" flag.
Attachment #8865741 - Flags: review?(snorp)
Move the code that actually performs shutdown from BrowserApp to
GeckoApplication, so we can shutdown even without an active BrowserApp.
From inside GeckoApp/BrowserApp, all shutdown now go through
finishAndShutdown(), which destroys the Activity before shutting down.
Attachment #8865742 - Flags: review?(snorp)
GeckoAppShell.scheduleRestart was called from XPCOM toolkit when we
needed to restart after the Gecko thread exits. But because we made the
"Gecko:Exited" event contain a "restart" flag, we can handle that
entirely in Java now, so we don't need to call
GeckoAppShell.scheduleRestart anymore.
Attachment #8865743 - Flags: review?(snorp)
Remove GeckoInterface.doRestart now that it's no longer used.
Attachment #8865744 - Flags: review+
Attachment #8865741 - Flags: review?(snorp) → review+
Attachment #8865742 - Flags: review?(snorp) → review+
Attachment #8865743 - Flags: review?(snorp) → review+
Assignee: nobody → nchen
Status: NEW → ASSIGNED
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11495bc70755
1. Add "restart" flag for "Gecko:Exited" event; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/2458deaf6064
2. Move shutdown to GeckoApplication; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/632e8d8dd077
3. Remove GeckoAppShell.scheduleRestart; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/01cf56720e84
4. Remove GeckoInterface.doRestart; r=me
Depends on: 1365582
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 55 → mozilla55
You need to log in before you can comment on or make changes to this bug.