Remove GeckoInterface.doRestart

RESOLVED FIXED in Firefox 55

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

50 Branch
Firefox 55
Unspecified
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(4 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

a year ago
Created attachment 8865741 [details] [diff] [review]
1. Add "restart" flag for "Gecko:Exited" event (v1)

In the GeckoBundle data for the "Gecko:Exited" event, indicate whether
we should restart or not through the "restart" flag.
Attachment #8865741 - Flags: review?(snorp)
(Assignee)

Comment 2

a year ago
Created attachment 8865742 [details] [diff] [review]
2. Move shutdown to GeckoApplication (v1)

Move the code that actually performs shutdown from BrowserApp to
GeckoApplication, so we can shutdown even without an active BrowserApp.
From inside GeckoApp/BrowserApp, all shutdown now go through
finishAndShutdown(), which destroys the Activity before shutting down.
Attachment #8865742 - Flags: review?(snorp)
(Assignee)

Comment 3

a year ago
Created attachment 8865743 [details] [diff] [review]
3. Remove GeckoAppShell.scheduleRestart (v1)

GeckoAppShell.scheduleRestart was called from XPCOM toolkit when we
needed to restart after the Gecko thread exits. But because we made the
"Gecko:Exited" event contain a "restart" flag, we can handle that
entirely in Java now, so we don't need to call
GeckoAppShell.scheduleRestart anymore.
Attachment #8865743 - Flags: review?(snorp)
(Assignee)

Comment 4

a year ago
Created attachment 8865744 [details] [diff] [review]
4. Remove GeckoInterface.doRestart (v1)

Remove GeckoInterface.doRestart now that it's no longer used.
Attachment #8865744 - Flags: review+
Attachment #8865741 - Flags: review?(snorp) → review+
Attachment #8865742 - Flags: review?(snorp) → review+
Attachment #8865743 - Flags: review?(snorp) → review+
(Assignee)

Updated

a year ago
Assignee: nobody → nchen
Status: NEW → ASSIGNED

Comment 5

a year ago
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11495bc70755
1. Add "restart" flag for "Gecko:Exited" event; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/2458deaf6064
2. Move shutdown to GeckoApplication; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/632e8d8dd077
3. Remove GeckoAppShell.scheduleRestart; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/01cf56720e84
4. Remove GeckoInterface.doRestart; r=me

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/11495bc70755
https://hg.mozilla.org/mozilla-central/rev/2458deaf6064
https://hg.mozilla.org/mozilla-central/rev/632e8d8dd077
https://hg.mozilla.org/mozilla-central/rev/01cf56720e84
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Updated

a year ago
Depends on: 1365582
You need to log in before you can comment on or make changes to this bug.