1362191 - Remove GeckoInterface.doRestart

Status: RESOLVED FIXED

(GeckoView :: General, enhancement)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 1. Add "restart" flag for "Gecko:Exited" event (v1)

In the GeckoBundle data for the "Gecko:Exited" event, indicate whether
we should restart or not through the "restart" flag.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 2. Move shutdown to GeckoApplication (v1)

Move the code that actually performs shutdown from BrowserApp to
GeckoApplication, so we can shutdown even without an active BrowserApp.
From inside GeckoApp/BrowserApp, all shutdown now go through
finishAndShutdown(), which destroys the Activity before shutting down.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 3. Remove GeckoAppShell.scheduleRestart (v1)

GeckoAppShell.scheduleRestart was called from XPCOM toolkit when we
needed to restart after the Gecko thread exits. But because we made the
"Gecko:Exited" event contain a "restart" flag, we can handle that
entirely in Java now, so we don't need to call
GeckoAppShell.scheduleRestart anymore.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: 4. Remove GeckoInterface.doRestart (v1)

Remove GeckoInterface.doRestart now that it's no longer used.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11495bc70755
1. Add "restart" flag for "Gecko:Exited" event; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/2458deaf6064
2. Move shutdown to GeckoApplication; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/632e8d8dd077
3. Remove GeckoAppShell.scheduleRestart; r=snorp
https://hg.mozilla.org/integration/mozilla-inbound/rev/01cf56720e84
4. Remove GeckoInterface.doRestart; r=me

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/11495bc70755
https://hg.mozilla.org/mozilla-central/rev/2458deaf6064
https://hg.mozilla.org/mozilla-central/rev/632e8d8dd077
https://hg.mozilla.org/mozilla-central/rev/01cf56720e84