Closed
Bug 1362224
Opened 7 years ago
Closed 7 years ago
Speed up setting *Action icon images during tab switch
Categories
(WebExtensions :: Frontend, defect)
WebExtensions
Frontend
Tracking
(firefox54 wontfix, firefox55 fixed)
RESOLVED
FIXED
mozilla55
People
(Reporter: kmag, Assigned: kmag)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
59 bytes,
text/x-review-board-request
|
aswan
:
review+
gchang
:
approval-mozilla-beta-
|
Details |
59 bytes,
text/x-review-board-request
|
aswan
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
aswan
:
review+
gchang
:
approval-mozilla-beta-
|
Details |
59 bytes,
text/x-review-board-request
|
aswan
:
review+
|
Details |
59 bytes,
text/x-review-board-request
|
aswan
:
review+
|
Details |
Selecting the icon and generating the CSS for these can be pretty expensive. We should try to cache both rather than recalculate them for every navigation and/or tab switch.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8864972 [details] Bug 1362224: Cache per-tab icon data for browserAction/pageAction. https://reviewboard.mozilla.org/r/136632/#review139738
Attachment #8864972 -
Flags: review?(aswan) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8864974 [details] Bug 1362224: Speed up permission checks a bit. https://reviewboard.mozilla.org/r/136636/#review139740
Attachment #8864974 -
Flags: review?(aswan) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8864978 [details] Bug 1362224: Cached normalized object for simple icon URLs. https://reviewboard.mozilla.org/r/136638/#review139744 ::: toolkit/components/extensions/ExtensionUtils.jsm:326 (Diff revision 1) > } > > // Manages icon details for toolbar buttons in the |pageAction| and > // |browserAction| APIs. > let IconDetails = { > + iconCache: new DefaultWeakMap(() => new Map()), add a comment documenting the structure please.
Attachment #8864978 -
Flags: review?(aswan) → review+
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8864982 [details] Bug 1362224: Cache tab incognito state. https://reviewboard.mozilla.org/r/136644/#review139748
Attachment #8864982 -
Flags: review?(aswan) → review+
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8864973 [details] Bug 1362224: requestAnimationFrame before changing browserAction/pageAction buttons. https://reviewboard.mozilla.org/r/136634/#review139752 r=me with the `promiseAnimationFrame()` changes we discussed on IRC
Attachment #8864973 -
Flags: review?(aswan) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 15•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/80e82d441dca0df90cd4c994da887ee19459d8f3 Bug 1362224: Cache per-tab icon data for browserAction/pageAction. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/aa1764039854ed505e3e6690b07598653a69ccf3 Bug 1362224: requestAnimationFrame before changing browserAction/pageAction buttons. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/72a3bc67fccb4179fc87aec626bd5cf8051e3bd0 Bug 1362224: Speed up permission checks a bit. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/d4013bac9f353468739db52fcd7ea724178d6232 Bug 1362224: Cached normalized object for simple icon URLs. r=aswan https://hg.mozilla.org/integration/mozilla-inbound/rev/79511b594380b3d30a89db9084182f5cb5b1f588 Bug 1362224: Cache tab incognito state. r=aswan
Comment 16•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/80e82d441dca https://hg.mozilla.org/mozilla-central/rev/aa1764039854 https://hg.mozilla.org/mozilla-central/rev/72a3bc67fccb https://hg.mozilla.org/mozilla-central/rev/d4013bac9f35 https://hg.mozilla.org/mozilla-central/rev/79511b594380
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee | ||
Comment 17•7 years ago
|
||
Comment on attachment 8864972 [details] Bug 1362224: Cache per-tab icon data for browserAction/pageAction. Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: This patch improves tab switch performance when WebExtension pageAction or browserAction buttons are active. Since Screenshots uses a browserAction button, this should help offset the performance impact of enabling it in 54. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: No [Needs manual test from QE? If yes, steps to reproduce]: N/A [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: Low-risk [Why is the change risky/not risky?]: The changes are fairly simple, and should only risk affecting add-ons with per-tab pageAction and browserAction icons, which are relatively rare. [String changes made/needed]: None
Attachment #8864972 -
Flags: approval-mozilla-beta?
Assignee | ||
Comment 18•7 years ago
|
||
Comment on attachment 8864974 [details] Bug 1362224: Speed up permission checks a bit. Approval Request Comment [Feature/Bug causing the regression]: N/A [User impact if declined]: This should speed up a number of operations in WebExtension code, and should help mitigate the performance impact of enabling Screenshots in beta. [Is this code covered by automated tests?]: Yes [Has the fix been verified in Nightly?]: N/A [Needs manual test from QE? If yes, steps to reproduce]: N/A [List of other uplifts needed for the feature/fix]: None [Is the change risky?]: No. [Why is the change risky/not risky?]: This is a very simple change which replaces a fairly expensive operation with an cheaper equivalent. [String changes made/needed]: None.
Attachment #8864974 -
Flags: approval-mozilla-beta?
Updated•7 years ago
|
Blocks: webext-perf
Comment 19•7 years ago
|
||
Screenshots will go live in Fx55 so we don't have to uplift these patches in 54. Beta54-. Mark 54 won't fix.
status-firefox54:
--- → wontfix
Updated•7 years ago
|
Attachment #8864972 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Updated•7 years ago
|
Attachment #8864974 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•