1362234 - Update Firefox Screenshots to version 6.6.1

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

This bug updates the version of Firefox Screenshots in the tree from 6.6.0 to 6.6.1.

The changes address Talos regressions tracked by bug 1361792.

Comment 1

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1362234 - Fix Screenshots Talos regressions by removing WebExtension startup delay and removing tab 'activated' event handler;

Review commit: https://reviewboard.mozilla.org/r/136348/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136348/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8864705 [details]
Bug 1362234 - Fix Screenshots Talos regressions by removing WebExtension startup delay and removing tab 'activated' event handler;

https://reviewboard.mozilla.org/r/136348/#review139432

::: browser/extensions/screenshots/webextension/background/main.js:202
(Diff revision 1)
>      browser.browserAction.disable(tabId);
>      setIconActive(true, tabId);
>    }
>  
>    browser.tabs.onUpdated.addListener(catcher.watchFunction((id, info, tab) => {
>      if (info.url && tab.active) {

Since we're getting rid of the onActivated listener, we should also do this for non-active tabs.

Comment 3

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Changelog: https://github.com/mozilla-services/screenshots/blob/latest-firefox-export/CHANGELOG.md

Manual Try push, with this commit and the pref-flipping commit:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=68739157cf6dc6d8dbb3c2406d7894a9d3eb08e3

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8864705 [details]
Bug 1362234 - Fix Screenshots Talos regressions by removing WebExtension startup delay and removing tab 'activated' event handler;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/136348/diff/1-2/

Comment 5

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Addressed review feedback, re-pushed to Try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=036449f37f161db5b236a804b8d60a2b7b479755

:kmag, I don't have level 3 commit access. Would you mind pushing this patch to autoland?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a12bfc0263ac
Fix Screenshots Talos regressions by removing WebExtension startup delay and removing tab 'activated' event handler; r=kmag

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a12bfc0263ac