Stop running commands during recording for BlobImage

RESOLVED FIXED in Firefox 56

Status

()

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

(Blocks 1 bug)

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment, 1 obsolete attachment)

Currently, DrawTargetRecording runs all of the commands that it's recording while recording. We need to not do this.
One impediment to fixing this now is that SourceSurfacesRecording wrap a real SourceSurface. If you call GetDataSurface() on it, it calls the real SourceSurface's GetDataSurface(). The plan is to make GetDataSurface() return nullptr on SourceSurfaceRecording and then not call GetDataSurface() while painting.

Updated

2 years ago
Whiteboard: [gfx-noted]
Posted patch Remove the playback (obsolete) — Splinter Review
Assignee: nobody → jmuizelaar
Posted patch patchSplinter Review
I have this split up in a bunch of pieces if you'd prefer to review it that way, but it shouldn't be too bad to review all at once.
Attachment #8875008 - Attachment is obsolete: true
Attachment #8876740 - Flags: review?(lsalzman)
Comment on attachment 8876740 [details] [diff] [review]
patch

Review of attachment 8876740 [details] [diff] [review]:
-----------------------------------------------------------------

This keeps around mFinalDT but mostly doesn't use it (except for when creating a PathBuilder). All playback is ripped out and we'll no longer hold references to things to mFinalDT::GraidentStops or SourceSurfaces etc.
Attachment #8876740 - Flags: review?(lsalzman) → review+

Comment 5

2 years ago
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fc0a10e36093
Stop running commands during recording for BlobImage. r=lsalzman

Comment 6

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/fc0a10e36093
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Depends on: 1440559
You need to log in before you can comment on or make changes to this bug.