Closed Bug 1362248 Opened 7 years ago Closed 5 years ago

Disabled on Windows: dom/canvas/test/reftest/webgl-color-test.html?native-gl == dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png | image comparison, max difference: 255, number of differing pixels: 41280

Categories

(Core :: Graphics: CanvasWebGL, defect, P3)

x86_64
Windows 10
defect

Tracking

()

RESOLVED INACTIVE

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Whiteboard: [gfx-noted][stockwell disabled])

Attachments

(1 file, 1 obsolete file)

Priority: -- → P3
Whiteboard: [gfx-noted]
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Bulk priority update of open intermittent test failure bugs. 

P3 => P5

https://bugzilla.mozilla.org/show_bug.cgi?id=1381960
Priority: P3 → P5
https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → INCOMPLETE
This has started failing pretty often since this push https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&fromchange=122d31260faaad8981c779d3f90fe56bdcdcfa8a&filter-searchStr=a95e4556976175e412c2d3d3a76e031882cdbfca&selectedJob=171242816 

New failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=171242816&repo=mozilla-inbound&lineNumber=43553

Joel, Robert could you take a look? Thank you.
Status: RESOLVED → REOPENED
Flags: needinfo?(rwood)
Flags: needinfo?(jmaher)
Resolution: INCOMPLETE → ---
I saw 3 different "frequent" failures on try pushes, I wanted to see how often they showed up- we switched hardware which has a different video card and will render tests differently.  I saw many other frequent reftest intermittent failures go away- I suspect it will be fixing X intermittents and adding X new ones for the same overall failure rate.
Flags: needinfo?(rwood)
Flags: needinfo?(jmaher)
in looking at this we are not able to use gl:
13:54:36     INFO -  REFTEST TEST-START | file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-color-test.html?native-gl == file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png
13:54:36     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(webgl.force-layers-readback,false)
13:54:36     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(media.useAudioChannelAPI,false)
13:54:36     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(webgl.force-enabled,false)
13:54:36     INFO -  REFTEST INFO | SET PREFERENCE pref(webgl.force-enabled,true)
13:54:36     INFO -  REFTEST INFO | SET PREFERENCE pref(media.useAudioChannelAPI,true)
13:54:36     INFO -  REFTEST INFO | SET PREFERENCE pref(webgl.disable-angle,true)
13:54:36     INFO -  REFTEST TEST-LOAD | file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-color-test.html?native-gl | 93 / 106 (87%)
13:54:36     INFO -  JavaScript warning: file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-utils.js, line 58: Error: WebGL warning: Exceeded 16 live WebGL contexts for this principal, losing the least recently used one.
13:54:36     INFO -  WebGL(000001FC2A21E000)::ForceLoseContext
13:54:36     INFO -  JavaScript warning: file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-utils.js, line 58: Error: WebGL warning: Disallowing antialiased backbuffers due to blacklisting.
13:54:36     INFO -  Can't find symbol 'wglCreatePbufferARB'.
13:54:36     INFO -  Can't find symbol 'wglDestroyPbufferARB'.
13:54:36     INFO -  Can't find symbol 'wglGetPbufferDCARB'.
13:54:36     INFO -  Can't find symbol 'wglReleasePbufferDCARB'.
13:54:36     INFO -  Can't find symbol 'wglChoosePixelFormatARB'.
13:54:36     INFO -  Can't find symbol 'wglGetExtensionsStringARB'.
13:54:36     INFO -  JavaScript warning: file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-utils.js, line 58: Error: WebGL warning: Failed to create WebGL context: WebGL creation failed:
13:54:36     INFO -  * Error during native OpenGL init.
13:54:36     INFO -  * Exhausted GL driver caps.
13:54:36     INFO -  * Exhausted GL driver options.
13:54:36     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(webgl.disable-angle,false)
13:54:36     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(media.useAudioChannelAPI,false)
13:54:36     INFO -  REFTEST INFO | RESTORE PREFERENCE pref(webgl.force-enabled,false)
13:54:36     INFO -  REFTEST INFO | SET PREFERENCE pref(webgl.force-enabled,true)
13:54:36     INFO -  REFTEST INFO | SET PREFERENCE pref(media.useAudioChannelAPI,true)
13:54:36     INFO -  REFTEST INFO | SET PREFERENCE pref(webgl.disable-angle,true)
13:54:36     INFO -  REFTEST TEST-LOAD | file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png | 93 / 106 (87%)
13:54:36    ERROR -  REFTEST TEST-UNEXPECTED-FAIL | file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/webgl-color-test.html?native-gl == file:///C:/Users/task_1522415361/build/tests/reftest/tests/dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png | image comparison, max difference: 255, number of differing pixels: 41280

taken from this log on machine 041:
https://taskcluster-artifacts.net/WgEKtPBSSIGeOmRIZ6TCcA/0/public/logs/live_backing.log

possibly this is a case of us not using the intel graphics card and defaulting to the built in onboard one?
Flags: needinfo?(mcornmesser)
Attached patch bug_1362248_win.patch (obsolete) — Splinter Review
Joel, please take a look at this patch. I'm not sure I've done it right since this is my first reftest manifest edit. Thanks.
Attachment #8964072 - Flags: review?(jmaher)
Comment on attachment 8964072 [details] [diff] [review]
bug_1362248_win.patch

Review of attachment 8964072 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/canvas/test/reftest/reftest.list
@@ +142,4 @@
>  
>  # Force native GL (Windows):
>  skip-if(!winWidget) pref(webgl.disable-angle,true) == webgl-color-test.html?native-gl  wrapper.html?colors-no-alpha.png
> +skip-if(winWidget) == webgl-color-test.html?native-gl wrapper.html?colors-no-alpha.png

for reftest we need to add everything to the same line- so unfortunately this was already skipped everywhere except windows, and now we will be skipping it on windows- so:
skip-if(true) pref(webgl.disable-angle,true) == webgl-color-test.html?native-gl wrapper.html?colors-no-alpha.png

I have a pending question to see why the GL context isn't rendering- possibly there is an issue with the graphics card and we can fix that.
Attachment #8964072 - Flags: review?(jmaher) → review-
Thank you for the explanation. I've made the modifications you said but this can wait until the situation about the tests is clear. This is just to be available if it's needed. Thanks
Attachment #8964072 - Attachment is obsolete: true
Attachment #8964089 - Flags: review?(jmaher)
 > possibly this is a case of us not using the intel graphics card and
> defaulting to the built in onboard one?

I compared the node logs and the test logs. It looks like the Intel card is being used at the time of the tests. Currently if the node is not using the Intel card generic worker will not start.
Flags: needinfo?(mcornmesser)
Comment on attachment 8964089 [details] [diff] [review]
Disable this test

Review of attachment 8964089 [details] [diff] [review]:
-----------------------------------------------------------------

lets disable this- and let the graphics team figure out a path to get this re-enabled.
Attachment #8964089 - Flags: review?(jmaher) → review+
:milan- on the new hardware we get cases where the GL fails to render and causes test failures- I am not sure what other cases we are hitting, this bug is the only highly frequent failure I see.
Flags: needinfo?(milan)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8982e01b201f
Disable dom/canvas/test/reftest/webgl-color-test.html?native-gl == dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png for frequent failures. r=jmaher
Keywords: checkin-needed
I think the failure is independent of the test in question, and just a result of multiple tests running and things not cleaning up in time:
Error: WebGL warning: Exceeded 16 live WebGL contexts for this principal, losing the least recently used one.
Error: WebGL warning: Failed to create WebGL context: WebGL creation failed:
13:54:36     INFO -  * Error during native OpenGL init.
13:54:36     INFO -  * Exhausted GL driver caps.
13:54:36     INFO -  * Exhausted GL driver options.

And once we don't have a GL context, well, the result is going to be blank and we'll see that difference.

It's too bad we have to disable this.  Basically, any test that fails after we get the "Exceeded 16 live WebGL contexts..." is failing through no fault of its own.

Perhaps splitting the test in two/three may help here?  Jeff, what do you think?
Flags: needinfo?(milan) → needinfo?(jgilbert)
I don't think it's context loss, but perhaps it's related.
The unusual thing about this test is that it is our native-gl test on windows. It's possible we just need to force-enable gl on this test. (unless we're already trying that)
We should really surface better reasons than we currently do.
Flags: needinfo?(jgilbert)
The leave-open keyword is there and there is no activity for 6 months.
:jgilbert, maybe it's time to close this bug?
Flags: needinfo?(jgilbert)
Status: REOPENED → RESOLVED
Closed: 7 years ago5 years ago
Flags: needinfo?(jgilbert)
Keywords: leave-open
Resolution: --- → FIXED
Assignee: nobody → csabou
Assignee: csabou → nobody
The leave-open was there because this test was disabled everywhere with c#17 so it's just disabled and not fixed. If no one cares about this test then it can remain like this. Unfortunately I am not in a position to fix this kind of failures.
Whiteboard: [gfx-noted][stockwell unknown] → [gfx-noted][stockwell disabled]
If we have to have pointless-bean-counting, I wish we could have a style of it that doesn't generate so much bugspam. Fortunately, there's a resolution for "this test is disabled, but really, nobody is ever going to do anything about it."
OS: Unspecified → Windows 10
Hardware: Unspecified → x86_64
Resolution: FIXED → INACTIVE
Summary: Intermittent dom/canvas/test/reftest/webgl-color-test.html?native-gl == dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png | image comparison, max difference: 255, number of differing pixels: 41280 → Disabled on Windows: dom/canvas/test/reftest/webgl-color-test.html?native-gl == dom/canvas/test/reftest/wrapper.html?colors-no-alpha.png | image comparison, max difference: 255, number of differing pixels: 41280
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: