1362258 - Reduce ref-counting overhead of TrackBuffersManager::AppendData()

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[JW Wang [:jwwang] [:jw_wang]]

http://searchfox.org/mozilla-central/rev/6580dd9a4eb0224773897388dba2ddf5ed7f4216/dom/media/mediasource/TrackBuffersManager.cpp#127

We can pass already_AddRefed<MediaByteBuffer> to InvokeAsync to avoid unnecessary AddRef/Release pairs.

Comment 1

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1362258 - Reduce ref-counting overhead of TrackBuffersManager::AppendData().

http://searchfox.org/mozilla-central/rev/6580dd9a4eb0224773897388dba2ddf5ed7f4216/dom/media/mediasource/TrackBuffersManager.cpp#127

We can pass already_AddRefed<MediaByteBuffer> to InvokeAsync to avoid unnecessary AddRef/Release pairs.

Review commit: https://reviewboard.mozilla.org/r/136356/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136356/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8864717 [details]
Bug 1362258 - Reduce ref-counting overhead of TrackBuffersManager::AppendData().

https://reviewboard.mozilla.org/r/136356/#review139518

::: dom/media/mediasource/TrackBuffersManager.cpp:129
(Diff revision 1)
> +  MSE_DEBUG("Appending %" PRIuSIZE " bytes", data->Length());
>  
>    mEnded = false;
>  
> -  return InvokeAsync<RefPtr<MediaByteBuffer>, SourceBufferAttributes&&>(
> -           GetTaskQueue(), this, __func__,
> +  return InvokeAsync(GetTaskQueue(), this, __func__,
> +    &TrackBuffersManager::DoAppendData, data.forget(), aAttributes);

why don't you pass aData as is?

Comment 3

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8864717 [details]
Bug 1362258 - Reduce ref-counting overhead of TrackBuffersManager::AppendData().

https://reviewboard.mozilla.org/r/136356/#review139518

> why don't you pass aData as is?

We have aData->Length() at #123.

Comment 4

[JW Wang [:jwwang] [:jw_wang]]

Thanks for the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0bcfd4faec8c
Reduce ref-counting overhead of TrackBuffersManager::AppendData(). r=jya

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0bcfd4faec8c