Closed Bug 1362284 Opened 3 years ago Closed 3 years ago

Assign the background thread before flushing pending events at GamepadEventChannelParent

Categories

(Core :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: daoshengmu, Assigned: daoshengmu)

Details

Attachments

(1 file)

GamepadEventChannelParent will flush pending events and dispatch events at its constructor. But the background thread is not assigned yet, it will cause nullptr crash.
Assignee: nobody → dmu
Comment on attachment 8864734 [details]
Bug 1362284 - Assign the background thread before flushing pending events at GamepadEventChannelParent;

https://reviewboard.mozilla.org/r/136388/#review139464

LGTM, thanks :)
Attachment #8864734 - Flags: review?(cleu) → review+
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f4e34d6481e8
Assign the background thread before flushing pending events at GamepadEventChannelParent; r=Lenzak
https://hg.mozilla.org/mozilla-central/rev/f4e34d6481e8
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.