1362390 - make Base64Encode on nsString more tolerant of allocation failures

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Nathan Froyd [:froydnj]]

Bug 1362194 is making Base64Decode more tolerant of allocation failures, we might as well apply the same treatment to Base64Encode as well, since that can get called from script too.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: make Base64Encode tolerant of allocation failures

This patch is essentially the same as bug 1362194, just done as a single patch.
This patch is dependent on some of the bits added in said bug.

crash-stats says we have a few crashes in this function and its callees, so
this is addressing a problem...though me might just be moving the crash
someplace else...

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4b157d9d0e7
make Base64Encode tolerant of allocation failures; r=mccr8

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a4b157d9d0e7

Comment 4

[Nathan Froyd [:froydnj]]

Comment on attachment 8864852 [details] [diff] [review]
make Base64Encode tolerant of allocation failures

Approval Request Comment
[Feature/Bug causing the regression]: many eons ago
[User impact if declined]: crashes (not in this bug, but this function is definitely implicated in crash signatures)
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: This is required for a clean uplift of bug 1362194, due to sloppy coding on the part of the author.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: We are now failing on OOM on a common codepath.
[String changes made/needed]: None.

Comment 5

[Nathan Froyd [:froydnj]]

Note that this bug and bug 1362194 landed in the same push on inbound, so that's why we didn't see any problems with bug 1362194 compiling on inbound.

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8864852 [details] [diff] [review]
make Base64Encode tolerant of allocation failures

Required by bug 1362194. Beta54+. Should be in 54 beta 7.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5ac536c5ce06

Comment 8

[Andrei Vaida [:avaida]]

(In reply to Nathan Froyd [:froydnj] from comment #4)
> [Is this code covered by automated tests?]: yes
> [Has the fix been verified in Nightly?]: no
> [Needs manual test from QE? If yes, steps to reproduce]: no

Setting qe-verify- based on Nathan's assessment on manual testing needs and the fact that this fix has automated coverage.