Closed Bug 1362396 Opened 7 years ago Closed 7 years ago

Make CI tests for DevEdition visible on Treeherder

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: spacurar, Assigned: spacurar)

References

Details

Attachments

(2 files, 2 obsolete files)

Please make the tests for DevEdition platforms visible on treeherder.
Component: Treeherder → Visibility Requests
Assignee: nobody → spacurar
Attached patch bug_1362396_linux64-talos.patch (obsolete) — Splinter Review
I added the devedition variant to mozilla-inbound. Is this the correct place or should it be added to mozilla-beta/jamun?
Attachment #8870068 - Flags: review?(kmoir)
Ah if this bug is for adding support for devedition tests, then the Taskcluster component is more appropriate.

From the current bug summary it seemed as though this was requesting that the sheriffs change the visibility of an existing job via the "visibility profiles" feature.
Component: Visibility Requests → Task Configuration
Product: Tree Management → Taskcluster
Version: --- → unspecified
Comment on attachment 8870068 [details] [diff] [review]
bug_1362396_linux64-talos.patch

We should test it first on jamun before we land the patches on inbound.

On jamun you will need something like this add talos tests
diff --git a/taskcluster/ci/test/test-platforms.yml b/taskcluster/ci/test/test-platforms.yml
--- a/taskcluster/ci/test/test-platforms.yml
+++ b/taskcluster/ci/test/test-platforms.yml
@@ -55,16 +55,17 @@ linux64/opt:
 linux64-devedition/opt:
     build-platform: linux64-devedition-nightly/opt
     test-sets:
         - common-tests
         - web-platform-tests
         - opt-only-tests
         - desktop-screenshot-capture
         - awsy
+        - talos


The current patch doesn't apply cleanly to jamun.

Also, if you look at taskcluster/ci/test/tests.yml  the talos tests are all specify  run-on-projects and jamun is not liated as a branch, so this will have to be updated.
Attachment #8870068 - Flags: review?(kmoir) → review-
Enabled jamun for talos tests in taskcluster/ci/test/tests.yml, added talos for linux64-devedition/opt test builder, added the variant for devedition.
Attachment #8870788 - Flags: review?(kmoir)
Sorry for the previous patch, it had a flaw in the code. I fixed it now.

Enabled jamun for talos tests in taskcluster/ci/test/tests.yml, added talos for linux64-devedition/opt test builder, added the variant for devedition.
Attachment #8870788 - Attachment is obsolete: true
Attachment #8870788 - Flags: review?(kmoir)
Attachment #8870792 - Flags: review?(kmoir)
Comment on attachment 8870792 [details] [diff] [review]
bug_1362396_v2_linux64-talos-jamun.patch

Looks good.  We can hold off landing this until we have the corresponding buildbot jobs enabled, otherwise the jobs will just fail with a payload exception.
Attachment #8870792 - Flags: review?(kmoir) → review+
Blocks: 1359595
Attachment #8870068 - Attachment is obsolete: true
This is the diff after enabling linux64 talos on jamun.
I believe this can be marked as fixed now.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: