1362397 - Add a new win8 R-e10s-qr job on the graphics tree

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement)

Description

[Kartikaya Gupta (email:[e-mail])]

I would like to see a new win8 job added, but only on the graphics tree (for now). This job should be exactly the same as the existing R-e10s reftest jobs (R-e10s on opt, R-e10s1 and R-e10s2 on debug), except that it needs to run with the preference gfx.webrender.enabled set to true. I'd like this to show up on TreeHerder as R-e10s-qr ("qr" for "Quantum Render").

It seems like all the win8 jobs are currently scheduled by buildbot, so I don't think I can make this happen by fiddling with the in-tree taskcluster configs. If I'm wrong please let me know.

Note that this job will initially fail, once it is enabled I will green it up.

Comment 1

[Alin Selagea [:aselagea]]

Attachment: [bb-configs]bug_1362397.patch

Comment 2

[Alin Selagea [:aselagea]]

Attachment: [mozharness]bug_1362397.patch

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] AlinSelagea:bug1362397_add_TH_entries_for_R-qr > mozilla:master

Comment 4

[Alin Selagea [:aselagea]]

Builder diff:

--- old 2017-05-08 01:45:48.070034769 -0700
+++ new 2017-05-08 07:31:12.107109418 -0700
@@ -1,395 +1,395 @@
@@ -481,0 +482 @@ Windows 8 64-bit graphics opt test gtest
+Windows 8 64-bit graphics opt test reftest-qr-e10s ScriptFactory
@@ -581,0 +583,2 @@ Windows 8 64-bit graphics debug test gte
+Windows 8 64-bit graphics debug test reftest-qr-e10s-1 ScriptFactory
+Windows 8 64-bit graphics debug test reftest-qr-e10s-2 ScriptFactory

Comment 5

[Kim Moir [:kmoir] ET]

Comment on attachment 8865458 [details] [review]
[treeherder] AlinSelagea:bug1362397_add_TH_entries_for_R-qr > mozilla:master

Can you add someone on the pull request from the treeherder team to review this request?  Perhaps :emorley. I don't have rights to merge into this project anyways.

Comment 6

[Kim Moir [:kmoir] ET]

Alin, can you please provide a builder diff, thanks!

Comment 7

[Kim Moir [:kmoir] ET]

nevermind I see the builder diff in the comments :-)

Comment 8

[Alin Selagea [:aselagea]]

Comment on attachment 8865458 [details] [review]
[treeherder] AlinSelagea:bug1362397_add_TH_entries_for_R-qr > mozilla:master

I updated the PR here: https://github.com/mozilla/treeherder/pull/2457
@Ed: when you have some time, can you please take a look?

Comment 9

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/fca154f5f579af3cb7c2ff13cd3e758b481d375a
Bug 1362397 - Add support for Reftest QR e10s (#2457)

Comment 10

[Ed Morley [:emorley]]

Comment on attachment 8865458 [details] [review]
[treeherder] AlinSelagea:bug1362397_add_TH_entries_for_R-qr > mozilla:master

Looks great, thank you :-)

Comment 11

[Alin Selagea [:aselagea]]

Comment on attachment 8865458 [details] [review]
[treeherder] AlinSelagea:bug1362397_add_TH_entries_for_R-qr > mozilla:master

https://github.com/mozilla/treeherder/commit/fca154f5f579af3cb7c2ff13cd3e758b481d375a

Thanks Ed!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae978f8a16bb
Add a new win8 R-e10s-qr job on the graphics tree, r=kmoir,aobreja

Comment 13

[Alin Selagea [:aselagea]]

Comment on attachment 8865456 [details] [diff] [review]
[bb-configs]bug_1362397.patch

https://hg.mozilla.org/build/buildbot-configs/rev/3963898f3591
https://hg.mozilla.org/build/buildbot-configs/rev/d1c02442a850

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae978f8a16bb

Comment 15

[Kartikaya Gupta (email:[e-mail])]

The new jobs on the graphics branch are failing with this error:
  Required config file not set! (use --config-file option)

Example log: https://treeherder.mozilla.org/logviewer.html#?job_id=99163599&repo=graphics&lineNumber=283

I believe the config.py needs an additional change to add the config_files property (I'm just guessing based on what happens for other suites). I'll attach a patch.

Comment 16

[Kartikaya Gupta (email:[e-mail])]

Attachment: [bb-configs] add config_files

If this looks good please land it as well, I probably don't have permissions to push to this repo.

Comment 17

[Alin Selagea [:aselagea]]

Comment on attachment 8867725 [details] [diff] [review]
[bb-configs] add config_files

Thanks!

Comment 18

[Alin Selagea [:aselagea]]

Comment on attachment 8867725 [details] [diff] [review]
[bb-configs] add config_files

https://hg.mozilla.org/build/buildbot-configs/rev/e00d70c60f29
https://hg.mozilla.org/build/buildbot-configs/rev/c72845569587

Comment 19

[Alin Selagea [:aselagea]]

The symbols for the new job look fine in staging TH: https://treeherder.allizom.org/#/jobs?repo=graphics&filter-searchStr=reftest-qr, so we should get the same in production TH once a new deploy happens.

Both opt and debug tests are failing at the moment, however, #c0 above seems to suggest that is expected and will need some work to green them up.

@kats: is there something else for me to help with on this bug?

Comment 20

[Kartikaya Gupta (email:[e-mail])]

(In reply to Alin Selagea [:aselagea][:buildduty] from comment #19)
> The symbols for the new job look fine in staging TH:
> https://treeherder.allizom.org/#/jobs?repo=graphics&filter-searchStr=reftest-
> qr, so we should get the same in production TH once a new deploy happens.

Agreed

> Both opt and debug tests are failing at the moment, however, #c0 above seems
> to suggest that is expected and will need some work to green them up.

Yes, this is expected. I plan to work on greening them up in bug 1365250.

> @kats: is there something else for me to help with on this bug?

I had one question - is there try syntax that will trigger the new jobs? I did a try push yeterday [1] with the syntax "try: -b do -p win64 -u reftest-qr-e10s[Windows 8] -t none[Windows 8]" to see if it would run the new jobs but it didn't seem to (I had to retrigger the build a number of times because of the windows build problems yesterday, but I finally got a green opt build and it didn't add the test job).

[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c18fc1a4241c466651fd245eda0cdbf2bab28df

Comment 21

[Alin Selagea [:aselagea]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #20)
 
> I had one question - is there try syntax that will trigger the new jobs? I
> did a try push yeterday [1] with the syntax "try: -b do -p win64 -u
> reftest-qr-e10s[Windows 8] -t none[Windows 8]" to see if it would run the
> new jobs but it didn't seem to (I had to retrigger the build a number of
> times because of the windows build problems yesterday, but I finally got a
> green opt build and it didn't add the test job).

I don't think that'll run on try since we only enabled it on graphics.

Comment 22

[Kartikaya Gupta (email:[e-mail])]

Ok, thanks. This is fine for now, I can just force this configuration on try with a patch. Once I have it greened up and ready for promoting to tier-1 and the other branches, we can add it to try as well.