Disabled back button is too translucent

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Theme
P1
normal
VERIFIED FIXED
4 months ago
7 days ago

People

(Reporter: mstange, Assigned: johannh)

Tracking

(Depends on: 1 bug, {regression})

Trunk
Firefox 55
All
Mac OS X
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox53 unaffected, firefox54 unaffected, firefox55+ verified)

Details

(Whiteboard: [photon-visual][p2])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

4 months ago
[Tracking Requested - why for this release]: unintended visual regression in the primary UI

The back button's background's opacity changes when the button becomes disabled / enabled. This looks broken. Every new tab starts out with a disabled back button, so this happens all the time.

On Mac, native buttons keep their full opacity when they become disabled and only the glyph or text on top of them becomes less opaque. We should match that, and we did, until the recent changes.
(Reporter)

Updated

4 months ago
Blocks: 1352364

Updated

3 months ago
Whiteboard: [photon-visual][p2]

Updated

3 months ago
Flags: qe-verify?
Priority: -- → P2
Comment hidden (mozreview-request)

Comment 2

3 months ago
mozreview-review
Comment on attachment 8866298 [details]
Bug 1362408 - Fix disabled back button opacity on OSX.

https://reviewboard.mozilla.org/r/137920/#review141038

::: browser/themes/osx/browser.css:21
(Diff revision 1)
>  
>  :root {
>    --space-above-tabbar: 9px;
>    --tabs-toolbar-color: #333;
> +  /* This should be the same as --toolbarbutton-icon-fill, with reduced opacity. */
> +  --toolbarbutton-icon-fill-disabled: rgba(76, 76, 76, 0.4);

This seems rather fragile, and is in fact wrong with dark lightweight themes unless I'm missing something.
Attachment #8866298 - Flags: review?(dao+bmo) → review-

Comment 3

3 months ago
jwatt, http://searchfox.org/mozilla-central/search?q=context-fill-opacity suggests that context-fill-opacity exists in theory but isn't currently supported. What would it take to enable this?
Flags: needinfo?(jwatt)
tracking as ui regression in 55.
tracking-firefox55: ? → +

Updated

3 months ago
Assignee: nobody → jhofmann
Status: NEW → ASSIGNED
Iteration: --- → 55.5 - May 15
Priority: P2 → P1
(Assignee)

Comment 5

3 months ago
Short term we could also just override this variable for dark lightweight theme and add a TODO comment until context-fill-opacity gets enabled.

Comment 6

3 months ago
We're in no rush -- this can wait until we can fix it the right way.

Updated

3 months ago
Iteration: 55.5 - May 15 → 55.6 - May 29

Updated

3 months ago
Flags: qe-verify? → qe-verify+
QA Contact: brindusa.tot

Updated

3 months ago
Depends on: 1365926
(In reply to Dão Gottwald [::dao] from comment #3)
> jwatt, http://searchfox.org/mozilla-central/search?q=context-fill-opacity
> suggests that context-fill-opacity exists in theory but isn't currently
> supported. What would it take to enable this?

I've opened bug 1365926 to take a look at this.
Flags: needinfo?(jwatt)

Updated

3 months ago
Iteration: 55.6 - May 29 → 55.7 - Jun 12
The code fixes for bug 1365926 just landed, but there won't be a notification here since the bug won't be closed just yet until I wrap up the tests. You can still implement the alternative 'context-fill-opacity' based fix for this bug now though.
Flags: needinfo?(jhofmann)
Comment hidden (mozreview-request)
(Assignee)

Comment 10

2 months ago
(In reply to Jonathan Watt [:jwatt] from comment #8)
> The code fixes for bug 1365926 just landed, but there won't be a
> notification here since the bug won't be closed just yet until I wrap up the
> tests. You can still implement the alternative 'context-fill-opacity' based
> fix for this bug now though.

Thanks!
Flags: needinfo?(jhofmann)

Comment 11

2 months ago
mozreview-review
Comment on attachment 8866298 [details]
Bug 1362408 - Fix disabled back button opacity on OSX.

https://reviewboard.mozilla.org/r/137920/#review150170
Attachment #8866298 - Flags: review?(dao+bmo) → review+

Comment 12

2 months ago
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1dd8e8368519
Fix disabled back button opacity on OSX. r=dao

Comment 13

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1dd8e8368519
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
status-firefox-esr52: --- → unaffected
(Reporter)

Comment 14

2 months ago
Thank you for fixing this!

Updated

2 months ago
Depends on: 1374474
I tested this on Windows 10x 64 with Nightly 57.0a1(2017-08-09) and the back button background changes if the button is disabled or enabled. If it's disabled it becomes grayed out. Please tell me if this is this works as intended? Thanks
Flags: needinfo?(jhofmann)
(Assignee)

Comment 16

8 days ago
(In reply to ovidiu boca[:Ovidiu] from comment #15)
> I tested this on Windows 10x 64 with Nightly 57.0a1(2017-08-09) and the back
> button background changes if the button is disabled or enabled. If it's
> disabled it becomes grayed out. Please tell me if this is this works as
> intended? Thanks

You only need to test this on 55, where the disabled back button should not look different than the one in 54.
Flags: needinfo?(jhofmann)
Created attachment 8895856 [details]
back button.png

Please see the attached file. This is on Mac Os X 10.10 with FF 55 and FF 54, both back buttons are disabled.  From my point of view, the back button doesn't look the same, but please tell me your opinion. Thanks
(Assignee)

Comment 18

8 days ago
The point is that the button background should be the same, when the window is focused. In this screenshot one window is not focused.
Thanks for clearing this out, you are right, the button background is the same on FF 54 and FF 55, Mac OS X 10.10.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.