1362422 - Lack of partstat yields misleading appearance and empty selection box

Status: RESOLVED FIXED

(Calendar :: Lightning Only, defect)

Description

[jens.poenninghaus]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Firefox/31.0
Build ID: 20140825060242

Steps to reproduce:

- Invite lightning user to an event (import event with lightning user being an attendee)
- Ensure partstat=needs-action is missing, 
   e.g. copy event to editor remove parameter property insert modified event
- check derived event for x-lic errors (there should be none)

BEGIN:VEVENT
CREATED:20170505T143419Z
LAST-MODIFIED:20170505T143717Z
DTSTAMP:20170505T143717Z
UID:a8693d56-90db-401b-a6f4-965f20e9305a
SUMMARY:partstat-no-needs-action
ORGANIZER;CN=The organizer:mailto:[e-mail]
ATTENDEE;RSVP=TRUE;CN=the attendee:mailto:[e-mail]
DTSTART;TZID=Europe/Warsaw:20170505T100000
DTEND;TZID=Europe/Warsaw:20170505T110000
CLASS:PUBLIC
DESCRIPTION:partstat-no-needs-action
X-APPLE-NEEDS-REPLY:TRUE
END:VEVENT


Actual results:

- as lightning user
   * observe optical appearance of modified event resembling an already accepted event
   * check invitation list (modified event not present)
   * open event details: Observe reply drop down list populated with '' / an empty label.


Expected results:

Missing partstat should have been treated as partstat=needs-action
-> visual appearance of open invitation
-> list of open invitations
-> reply: 'i will confirm later'

Comment 1

[jens.poenninghaus]

Attachment: lightning_541_interpretation_no_partstat.png

Snapshot taken on lightning 5.4.1. Mark that both events still need confirmation. Mark that event on right hand side has empty label in 'reply' selection. Mark the difference in appearance of those two events.

Comment 2

[[:MakeMyDay]]

Attachment: UseDeafultForMissingPartstatParam-V1.diff

This patch takes care to display the 'I will confirm later' label in the summary dialog if the param is completely missing. The partstat itself is not added until the user will actively choose another partstat.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ed2940d5db2f
Display default partstat value in event summary dialog if the parameter is missing in attendee property. r=philipp

Comment 4

[Jorg K (CEST = GMT+2)]

Beta (TB 56, Calendar 5.8):
https://hg.mozilla.org/releases/comm-beta/rev/f25750d3bb82cc305dffa01dc888a52667c97eba

Comment 5

[Jorg K (CEST = GMT+2)]

ESR 52.3, Calendar 5.4.3:
https://hg.mozilla.org/releases/comm-esr52/rev/4265c16f92d3