1362445 - Console error when right-clicking on a browserAction with no context menus defined

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement)

Description

[Bob Silverberg [:bsilverberg]]

I noticed this when doing some work on browserAction telemetry. If you right-click on a browserAction, and there are no extensions loaded that use the contextmenus API, you get the following error in the console:

TypeError: global.actionContextMenu is not a function  -  ext-browserAction.js:310:11

If there are any extensions loaded that use the contextmenus API then this message does not appear. Discussing this with Luca, we believe this has to do with the lazy loading of the contextmenus API.

This doesn’t break anything, so perhaps it is something that can just be ignored, I’m not sure how critical it is to fix this.

Comment 1

[Tomislav Jovanovic :zombie]

it should be easy to avoid

Comment 2

[Tomislav Jovanovic :zombie]

Attachment: Bug 1362445 - Fix _action context menus when module is not loaded

Review commit: https://reviewboard.mozilla.org/r/136900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136900/

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8865233 [details]
Bug 1362445 - Fix _action context menus when module is not loaded

https://reviewboard.mozilla.org/r/136900/#review140062

This looks good, thanks zombie.  I just want to confirm, there is never a case where this code could run and want to force the loading of the menus module, correct?

Comment 4

[Tomislav Jovanovic :zombie]

> I just want to confirm, there is never a case where this code could 
> run and want to force the loading of the menus module, correct?

Correct, at least not now.  Chrome adds some items to browserAction's context menu even when the extension doesn't, and we were talking about doing something similar (can't find the bug), or when we implement menu-buttons (bug 1253419), but for now, if no extension has used the browser.contextMenus, we don't need to do anything here.

Comment 5

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8865233 [details]
Bug 1362445 - Fix _action context menus when module is not loaded

https://reviewboard.mozilla.org/r/136900/#review140200

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c8fe990d360
Fix _action context menus when module is not loaded r=bsilverberg,mixedpuppy

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c8fe990d360