1362504 - JSON Viewer should save using the original mime type

Status: RESOLVED FIXED

(DevTools :: JSON Viewer, defect)

Description

[Oriol Brufau [:Oriol]]

Bug 1349437 enabled saving the JSON contents via Ctrl+S in the JSON Viewer.

The problem is that it downloads with the application/json mime type, which forces a .json extension, even if the original type was application/manifest+json or application/vnd.mozilla.json.view.

The original type is available in the chrome process, but it's needed in the content one (see bug 1349437 comment 9).

Comment 1

[Oriol Brufau [:Oriol]]

Attachment: json-save-with-type.patch

I noticed converter-child.js has access to the HTTP headers, this can be used to obtain the content type. For data URIs I use a regexp. And application/json is the fallback value if I missed some other case.

Comment 2

[Oriol Brufau [:Oriol]]

Attachment: json-save-with-type-v2.patch

Adding a try..catch in case getResponseHeader throws (e.g. if you enable the JSON Viewer for "application/x-unknown-content-type", and the server doesn't send the Content-Type header).

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8865056 [details] [diff] [review]
json-save-with-type-v2.patch

Review of attachment 8865056 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.

Please see one inline comment

R+ assuming try is green

Try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d6d9298f14c5d708ea80a88743fb799c30d5eae

Honza

::: devtools/client/jsonview/converter-child.js
@@ +101,5 @@
> +    // which has been replaced by application/vnd.mozilla.json.view
> +    let originalType;
> +    if (request instanceof Ci.nsIHttpChannel) {
> +      try {
> +        originalType = request.getResponseHeader('Content-Type');

nit: use quotes for strings => "Content-Type"

Comment 4

[Oriol Brufau [:Oriol]]

Attachment: json-save-with-type-v3.patch

Fixed, but I don't see why simple quotes are considered bad. Now I hope the linter stops complaining. How to run linter tests locally?

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Oriol from comment #4)
> Fixed, but I don't see why simple quotes are considered bad.
It's just part of our code style rules.

> Now I hope the linter stops complaining. How to run linter tests locally?
See this MDN page
https://developer.mozilla.org/en-US/docs/ESLint

Honza

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5a5759c9547
Let JSON Viewer save with original content type. r=Honza

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a5a5759c9547