1362526 - Enable Simplify Print Feature by default (again) on Windows

Status: RESOLVED FIXED

(Toolkit :: Printing, enhancement, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

+++ This bug was initially created as a clone of Bug #1285607 +++

I had originally gotten sign-off from osunick to turn this on in 50, but then QA found some bugs and we turned it off on release.

Since then, it's been on by default on Linux on Nightly, and on by default on Windows up until Beta.

This bug is about turning the feature on by default on Windows.

Hey bogdan, would you be willing to take a look at this feature again now that we've fixed the bugs you found to ensure there are no other issues preventing us from throwing the switch?

Comment 1

[Bogdan Maris, Desktop Test Engineering]

Hi Mike, I have a few questions here first:
- Just to be super clear, the testing should be done on 54 Beta (after enabling the pref manually) and the plan would be to enable the feature in 54 beta on Windows only and let it ride the trains to 54 RC?
- Is there a deadline for when the testing should be completed?
- Are there any other fixes except https://mzl.la/2q16TUo that should be taken into consideration during testing?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

(In reply to Bogdan Maris, QA [:bogdan_maris] from comment #1)
> Hi Mike, I have a few questions here first:
> - Just to be super clear, the testing should be done on 54 Beta (after
> enabling the pref manually) and the plan would be to enable the feature in
> 54 beta on Windows only and let it ride the trains to 54 RC?

No, I don't think so. The only build where we've fixed all of the bugs that you identified last time are in Firefox 55 (Nightly).

So I believe the earliest we could ship this would be Firefox 55, so this is where we should test.

> - Is there a deadline for when the testing should be completed?

Preferably before the next uplift?

> - Are there any other fixes except https://mzl.la/2q16TUo that should be
> taken into consideration during testing?

I don't believe so.

Comment 3

[Matheus Longaray (:mlongaray)]

Attachment: Simplify-related bugs status

Here's a screenshot showing statuses of all the bugs related to Simplify that we've worked on so far. Hope that helps :)

Comment 4

[Bogdan Maris, Desktop Test Engineering]

Great, thanks for the info Mike and Matheus! 
I personally can't take ownership on this anymore due to my workload, but Ciprian Georgiu (one of my colleagues) has the time to accommodate this request and I will make sure he is up to date with this feature and will get started testing ASAP.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Hello Ciprian! What are the chances a QA pass can occur before the "soft code freeze"[1] that's happening on Nightly on June 5th?

[1]: https://groups.google.com/forum/#!topic/mozilla.dev.platform/p1LyRxPcEeQ

Comment 6

[Ciprian Georgiu, Desktop QA]

Hi Mike,

I've already started testing this feature and the pre-Beta sign off is scheduled to be completed on the 2nd of June. Does this plan sound reasonable to you?

Comment 7

[Mike Conley (:mconley) (:⚙️)]

(In reply to Ciprian Georgiu, QA [:ciprian_georgiu] from comment #6)
> Hi Mike,
> 
> I've already started testing this feature and the pre-Beta sign off is
> scheduled to be completed on the 2nd of June. Does this plan sound
> reasonable to you?

Yes.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

(In reply to Mike Conley (:mconley) from comment #7)
> Yes.

Thank you!

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Hey osunick, can I assume your approval for enabling this feature by default back in bug 1285607 for Firefox 50 also applies now? We've got green sign-off from QA (see release-drivers), but I only want to turn this thing on by default in Firefox 55 if Product is good with the timing.

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1362526 - Enable Simplify Page feature by default on Windows.

Review commit: https://reviewboard.mozilla.org/r/145520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145520/

Comment 11

[:Gijs (he/him)]

Comment on attachment 8874064 [details]
Bug 1362526 - Enable Simplify Page feature by default on Windows.

https://reviewboard.mozilla.org/r/145520/#review149468

rs=me on the pref flip, though do we want to re-check the Linux exception? If Linux is still buggy for some reason, we should remember to clarify this in the release notes, if any.

Comment 12

[Matheus Longaray (:mlongaray)]

As per comment #11, I re-checked the Linux exception and here's some results.

1) Bug 1306295 is still reproducible on Linux. Preview layout issue still happen when quickly toggling Simplify and/or switching between Portrait and Landscape mode.

2) Could not reproduce bug 1306297. Not sure if this still happens because bug 1365601 occurs when testing (internal print engine crash).

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7513f724a303
Enable Simplify Page feature by default on Windows. r=Gijs

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7513f724a303

Comment 15

[Julien Cristau [:jcristau]]

Added "Improved printing by using the Reader Mode" to the 55beta release notes

Comment 16

[Nick Nguyen [:osunick]]

(In reply to Mike Conley (:mconley) from comment #9)
> Hey osunick, can I assume your approval for enabling this feature by default
> back in bug 1285607 for Firefox 50 also applies now? We've got green
> sign-off from QA (see release-drivers), but I only want to turn this thing
> on by default in Firefox 55 if Product is good with the timing.

Approved!