1362537 - Re-disallow accept4 after bug 1361338 lands

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, enhancement)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Once bug 1361338 lands and only the parent process is registered for accessibility, we should be able to back out bug 1361238 and take away accept4 again.

All things considered it's not the worst system call to have to allow, because the process has to acquire a listening socket from a trusted source in order to use it, but the principle of least privilege applies.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Attachment: Bug 1362537 - Re-disallow accept4 in Linux content processes.

Review commit: https://reviewboard.mozilla.org/r/152726/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/152726/

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Comment on attachment 8881552 [details]
Bug 1362537 - Re-disallow accept4 in Linux content processes.

https://reviewboard.mozilla.org/r/152726/#review157846

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2fe9bcd421ff
Re-disallow accept4 in Linux content processes. r=gcp

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

For reference, I tested this locally: start orca, start Firefox with GNOME_ACCESSIBILITY=1, load some pages, then `orca -l`.

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2fe9bcd421ff