Closed Bug 1362569 Opened 2 years ago Closed Last year

1.21ms uninterruptible reflow at _lockTabSizing@chrome://browser/content/tabbrowser.xml:6073:17

Categories

(Firefox :: Tabbed Browser, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: rjward0, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [ohnoreflow][qf:p1:f64][fxperf:p1])

Attachments

(1 file, 1 obsolete file)

Here's the stack:

_lockTabSizing@chrome://browser/content/tabbrowser.xml:6073:17
removeTab@chrome://browser/content/tabbrowser.xml:2650:15
onxblclick@chrome://browser/content/tabbrowser.xml:7039:9


              tab.style.marginInlineStart =
                -(width + layoutData.scrollButtonWidth + layoutData.paddingStart) + "px";
Component: Untriaged → Tabbed Browser
Flags: qe-verify?
Priority: -- → P2
Whiteboard: [ohnoreflow][qf][photon-performance] → [ohnoreflow][qf:p1][photon-performance]
Flags: qe-verify? → qe-verify-
Priority: P2 → P3
Whiteboard: [ohnoreflow][qf:p1][photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:p2][reserve-photon-performance]
Priority: P3 → P4
Keywords: perf
Whiteboard: [ohnoreflow][qf:p2][reserve-photon-performance] → [ohnoreflow][qf:p1][reserve-photon-performance]
Whiteboard: [ohnoreflow][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:i60][qf:p1][reserve-photon-performance]
Whiteboard: [ohnoreflow][qf:i60][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:f60][qf:p1][reserve-photon-performance]
Whiteboard: [ohnoreflow][qf:f60][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:f61][qf:p1][reserve-photon-performance]
Whiteboard: [ohnoreflow][qf:f61][qf:p1][reserve-photon-performance] → [ohnoreflow][qf:f61][qf:p1][reserve-photon-performance] [fxperf]
Whiteboard: [ohnoreflow][qf:f61][qf:p1][reserve-photon-performance] [fxperf] → [ohnoreflow][qf:f61][qf:p1][fxperf]
We might be able to get away with using getBoundsWithoutFlushing here.
Whiteboard: [ohnoreflow][qf:f61][qf:p1][fxperf] → [ohnoreflow][qf:f61][qf:p1][fxperf:p2]
Whiteboard: [ohnoreflow][qf:f61][qf:p1][fxperf:p2] → [ohnoreflow][qf:f64][qf:p1][fxperf:p2]
Whiteboard: [ohnoreflow][qf:f64][qf:p1][fxperf:p2] → [ohnoreflow][qf:p1:f64][fxperf:p2]
Turns out I can indeed use getBoundsWithoutFlushing here.
Assignee: nobody → mconley
Whiteboard: [ohnoreflow][qf:p1:f64][fxperf:p2] → [ohnoreflow][qf:p1:f64][fxperf:p1]
Attachment #8992063 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Comment on attachment 8992064 [details]
Bug 1362569 - Don't flush layout when locking the tab size during tab close. r?dao

Dão Gottwald [::dao] has approved the revision.

https://phabricator.services.mozilla.com/D2140
Attachment #8992064 - Flags: review+
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f1a38fec70b
Don't flush layout when locking the tab size during tab close. r=dao
https://hg.mozilla.org/mozilla-central/rev/3f1a38fec70b
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Depends on: 1477461
You need to log in before you can comment on or make changes to this bug.