1362827 - Stylish - Edit button brought you to New style editor (protocol broken)

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[atlanto]

Stylish 2.0.7
https://addons.mozilla.org/en-US/firefox/addon/stylish/

STR:
1. Go to Add-ons Manager->User Styles
2. Clibk Edit button for any style you have

AR:
New style editor is opened. (chrome://stylish/content/edit.xul)

ER:
Style editor for the userstyle should be opened. (about:stylish-edit?id=...)

Also, 'Write New Style' brings you to
[former normal] about:stylish-edit
[current abnormal] chrome://stylish/content/edit.xul

Mozregression:
 7:30.66 INFO: Last good revision: ed010b85ea12896dd62015ae399e22d700f998e9
 7:30.66 INFO: First bad revision: e059178907999f07218e8d26f18a919b3ac9435a
 7:30.66 INFO: Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=ed010b85ea12896dd62015ae399e22d700f998e9&tochange=e059178907999f07218e8d26f18a919b3ac9435a

Comment 1

[Boris Zbarsky [:bzbarsky]]

In components/aboutStylishEdit.js this bit:

		channel.originalURI = aURI;

now also needs to do this bit:

  aSecurity_or_aLoadInfo.resultPrincipalURI = aURI;

in the "firefox 48 or later" branch.

Comment 2

[Boris Zbarsky [:bzbarsky]]

[Tracking Requested - why for this release]:

Comment 3

[Marcia Knous [:marcia]]

Tracking 55+ for this extension compat issue.

Comment 4

[Alice0775 White]

[Tracking Requested - why for this release]:

Comment 5

[Boris Zbarsky [:bzbarsky]]

This shouldn't be an issue with the updated patch in bug 1319111.  Is 56 really affected?

Comment 6

[Alice0775 White]

it seems e10s problem now

Comment 7

[Liz Henry (:lizzard) (relman/hg->git project)]

I can't tell if this is a Firefox issue or a problem with the extension. 
It seems unlikely to get fixed in time for 55 release.
Andy, what do you think?

Comment 8

[Andy McKay]

It's not something we'd look into unless its a WebExtension at this point.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Seriously, see comment 5.  I expect this should be fixed on all channels at this point.  Just needs testing to confirm...

Comment 10

[Boris Zbarsky [:bzbarsky]]

OK, I have just tested using the steps from comment 0 in a 55 beta and I see "about:stylish-edit?id=1" in the URL bar.  This works in both e10s and non-e10s modes.

I also tested in a 56 nightly.  Again, the URL is "about:stylish-edit?id=1" in both modes.

This looks fixed to me, by the updated patches for bug 1319111.