136291 - nsVoidArray.h assumes sizeof(void*) == sizeof(unsigned long)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Stuart Parmenter]

in nsVoidArray.h, it typedef's PtrBits to unsigned long.  I'm building on a
system where sizeof(void*) == 4 and sizeof(unsigned long) == 8.  This is only
causing warnings so far, but since it gets included in every file, it is driving
me nuts.

Comment 1

[Stuart Parmenter]

Attachment: proposed fix

Comment 2

[timeless]

Comment on attachment 78282 [details] [diff] [review]
proposed fix

make that or a nor ;-)

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

That's some of the inherited code from content.  Is there any standard type for
"int long enough to contain a void*"?

I'd prefer a solution that creates an int type known to be large enough for a
pointer, then use that.  That would generalize the solution.

I'm certain there are other spots in the code that rely on things like this.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

This is fixed by my patch in bug 312226 since it gets rid of the define compleatly.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

fixed with my patch in bug 312226