1362925 - Update webrender_bindings for cbindgen:0.1.7

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

I'd like to push a new update to cbindgen soon that has some breakingish changes.

So this commit,
1. Adds a cbindgen.toml that stores all the config properties for cbindgen
2. Updates the instructions (no more '-c wr' because of cbindgen.toml, and now '-o' is required for the output file).
3. Renames a few cbindgen annotations
4. Adds an annotation to WrTransformProperty to prevent it from generating operator==, as it depends on an operator== of WrMatrix that is no longer generated cbindgen no longer incorrectly generates operator== for array fields. This is kind of a hack.
5. Fixes webrender_ffi.h to not extern "C" the generated part because it does it for itself now.

This latest version adds some new formatting code that should make things nicer, and the ability to rename function arguments, struct fields and enum values.

It'd be nice to turn on renaming for struct fields so they conform better to Gecko style but that looks like it will be a lot of bustage.

https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=97226990

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1362925 - Update webrender_bindings for cbindgen:0.1.7

Review commit: https://reviewboard.mozilla.org/r/136960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/136960/

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Whoops, meant to link:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8b40f2a9e3700b443116fbfc8fc93e10b6af7a6a

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8865322 [details]
Bug 1362925 - Update webrender_bindings for cbindgen:0.1.7

https://reviewboard.mozilla.org/r/136960/#review140058

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Please make sure cbindgen-0.1.7 is pushed to crates.io before landing this change.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/0d025f2bfaaf
Update webrender_bindings for cbindgen:0.1.7 r=kats

Comment 6

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/0d025f2bfaaf