1362944 - Label runnables in dom/file/MutableBlobStorage.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

1. MutableBlobStorage is a main-thread-only class and is used by
   - Fetch indirectly using MutableBlobStreamListener (http://searchfox.org/mozilla-central/rev/8b70b0a5038ef9472fe7c53e04a70c978bb06aed/dom/fetch/Fetch.cpp#1285)
   - XMLHttpRequestMainThread (http://searchfox.org/mozilla-central/rev/8b70b0a5038ef9472fe7c53e04a70c978bb06aed/dom/xhr/XMLHttpRequestMainThread.cpp#3767)
2. An optional nsIEventTarget shall be provided into its constructor for labeling runnables on the main thread.
3. main-thread runnables dispatched by MutableBlobStorage are:
     http://searchfox.org/mozilla-central/search?q=DispatchToMainThread%7CAsyncWait%7CTimer%7CAbstractThread%7CProxyRelease%7CReleaseOnMainThread&case=false&regexp=true&path=dom%2Ffile%2FMutableBlobStorage.cpp

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 1: Accept nsIEventTarget in the CTOR of MutableBlobStorage to support runnable labeling.

1. Accept nsIEventTarget in the CTOR of MutableBlobStorage/MutableBlobStreamListener.
2. Do ProxyRelease and runnable dispatching via this event target.

:baku, may I have your review for these change?

Thanks!

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Part 2: Set proper event target to MutableBlobStorage when created from XMLHttpRequestMainThread.

There are 2 call sites to create MutableBlobStorage:
1. XMLHttpRequestMainThread: http://searchfox.org/mozilla-central/rev/7057a51c5cf29b5b115b1db19ace2cfe3fd83a0e/dom/xhr/XMLHttpRequestMainThread.cpp#3767
2. Fetch via MutableBlobStorageListener: http://searchfox.org/mozilla-central/rev/224cc663d54085994a4871ef464b7662e0721e83/dom/fetch/Fetch.cpp#1285

This patch will focus on call site#1.
Call site#2 will be addressed later in bug 1363318 instead.

:baku, May I have your review for these change?

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e447a0ae5dba
Part 1: Accept nsIEventTarget in the CTOR of MutableBlobStorage to support runnable labeling. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/ce4b4af56db5
Part 2: Set proper event target to MutableBlobStorage when created from XMLHttpRequestMainThread. r=baku

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e447a0ae5dba
https://hg.mozilla.org/mozilla-central/rev/ce4b4af56db5