1362946 - Label runnables in dom/file/nsHostObjectProtocolHandler.cpp

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

There is a timer in ReleasingTimerHolder::mTimer to release the BlobImpl handle in each nsHostObjectURI.
SystemGroup shall be a good option to label this timer if ReleasingTimerHolder::Notify() doesn't touch anything in web content.

Comment 1

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Set SystemGroup EventTarget to ReleasingTimerHolder.

1. Label ReleasingTimerHolder with SystemGroup since ReleasingTimerHolder
   touches nothing related to the web content but release the handle of
   the BlobImpl object.
2. Name ReleasingTimerHolder for telemetry[1].

:baku, may I have your review for these change? Thanks!

[1] http://searchfox.org/mozilla-central/rev/224cc663d54085994a4871ef464b7662e0721e83/xpcom/threads/nsTimerImpl.cpp#673-674

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8865767 [details] [diff] [review]
(v1) Set SystemGroup EventTarget to ReleasingTimerHolder.

Review of attachment 8865767 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/file/nsHostObjectProtocolHandler.cpp
@@ +462,5 @@
>      return NS_OK;
>    }
>  
> +  NS_IMETHOD
> +  GetName(nsACString & aName) override

naACString& aName

@@ +469,5 @@
> +    return NS_OK;
> +  }
> +
> +  NS_IMETHOD
> +  SetName(const char * aName) override

const char* aName

@@ +470,5 @@
> +  }
> +
> +  NS_IMETHOD
> +  SetName(const char * aName) override
> +  {

If this cannot be set, Just add an assertion. MOZ_CRASH(Something)

@@ +471,5 @@
> +
> +  NS_IMETHOD
> +  SetName(const char * aName) override
> +  {
> +    return NS_OK;

or return NOT_IMPLEMENTED;

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v2) (v1) Set SystemGroup EventTarget to ReleasingTimerHolder. r=baku

address comment 2.

treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d1f2f2b98eae93145a299af1827cc19774ed882

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15d644ff559f
Set SystemGroup EventTarget to ReleasingTimerHolder. r=baku

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15d644ff559f