Closed Bug 1362946 Opened 4 years ago Closed 4 years ago

Label runnables in dom/file/nsHostObjectProtocolHandler.cpp

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bevis, Assigned: bevis)

References

Details

(Whiteboard: [QDL][TDC-MVP][DOM])

Attachments

(1 file, 1 obsolete file)

There is a timer in ReleasingTimerHolder::mTimer to release the BlobImpl handle in each nsHostObjectURI.
SystemGroup shall be a good option to label this timer if ReleasingTimerHolder::Notify() doesn't touch anything in web content.
1. Label ReleasingTimerHolder with SystemGroup since ReleasingTimerHolder
   touches nothing related to the web content but release the handle of
   the BlobImpl object.
2. Name ReleasingTimerHolder for telemetry[1].

:baku, may I have your review for these change? Thanks!

[1] http://searchfox.org/mozilla-central/rev/224cc663d54085994a4871ef464b7662e0721e83/xpcom/threads/nsTimerImpl.cpp#673-674
Attachment #8865767 - Flags: review?(amarchesini)
Comment on attachment 8865767 [details] [diff] [review]
(v1) Set SystemGroup EventTarget to ReleasingTimerHolder.

Review of attachment 8865767 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/file/nsHostObjectProtocolHandler.cpp
@@ +462,5 @@
>      return NS_OK;
>    }
>  
> +  NS_IMETHOD
> +  GetName(nsACString & aName) override

naACString& aName

@@ +469,5 @@
> +    return NS_OK;
> +  }
> +
> +  NS_IMETHOD
> +  SetName(const char * aName) override

const char* aName

@@ +470,5 @@
> +  }
> +
> +  NS_IMETHOD
> +  SetName(const char * aName) override
> +  {

If this cannot be set, Just add an assertion. MOZ_CRASH(Something)

@@ +471,5 @@
> +
> +  NS_IMETHOD
> +  SetName(const char * aName) override
> +  {
> +    return NS_OK;

or return NOT_IMPLEMENTED;
Attachment #8865767 - Flags: review?(amarchesini) → review+
Pushed by btseng@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15d644ff559f
Set SystemGroup EventTarget to ReleasingTimerHolder. r=baku
https://hg.mozilla.org/mozilla-central/rev/15d644ff559f
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Whiteboard: [QDL][TDC-MVP][DOM]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.