Upgrade eslint-plugin-html to 2.0.x

RESOLVED FIXED in Firefox 55

Status

enhancement
RESOLVED FIXED
2 years ago
6 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

3 Branch
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

2 years ago
The 2.0.x series of eslint-plugin-html has --fix support. It would therefore be a good idea to update, as we can benefit from that when writing new rules, or developers using --fix.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8865356 - Flags: review?(dtownsend) → review?(jaws)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8865356 [details]
Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support.

https://reviewboard.mozilla.org/r/137008/#review141200

::: security/manager/ssl/tests/mochitest/mixedcontent/test_innerHtmlUnsecurePicture.html:32
(Diff revision 2)
>      }, 500);
>    }
>  
>    function afterNavigationTest()
>    {
> -    is(document.getElementById("buddy").innerHTML, "", "innerHTML back to previous");
> +    is(document.getElementById("buddy").innerHTML, "\n", "innerHTML back to previous");

These changes don't look like they belong in this patch.
Attachment #8865356 - Flags: review?(jaws) → review-
Assignee

Comment 4

2 years ago
mozreview-review-reply
Comment on attachment 8865356 [details]
Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support.

https://reviewboard.mozilla.org/r/137008/#review141200

> These changes don't look like they belong in this patch.

Sorry, I should have explained those - they are needed due to the newlines being added to the end of the html files. For some reason the innerHTML picks up the newline even after the </html>.
Assignee

Updated

2 years ago
Attachment #8865356 - Flags: review- → review?(jaws)
(In reply to Mark Banner (:standard8) from comment #4)
> Comment on attachment 8865356 [details]
> Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support.
> 
> https://reviewboard.mozilla.org/r/137008/#review141200
> 
> > These changes don't look like they belong in this patch.
> 
> Sorry, I should have explained those - they are needed due to the newlines
> being added to the end of the html files. For some reason the innerHTML
> picks up the newline even after the </html>.

We should get a DOM bug on file for this.

Comment 6

2 years ago
mozreview-review
Comment on attachment 8865356 [details]
Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support.

https://reviewboard.mozilla.org/r/137008/#review141224

rs=me
Attachment #8865356 - Flags: review?(jaws) → review+
Assignee

Updated

2 years ago
See Also: → 1363991
Assignee

Comment 7

2 years ago
mozreview-review-reply
Comment on attachment 8865356 [details]
Bug 1362947 - Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support.

https://reviewboard.mozilla.org/r/137008/#review141200

> Sorry, I should have explained those - they are needed due to the newlines being added to the end of the html files. For some reason the innerHTML picks up the newline even after the </html>.

Filed bug 1363991.

Comment 8

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e0f9c56c15f0
Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws
Backed out for linting failures, e.g. at accessible/tests/mochitest/jsat/doc_content_text.html:15:

https://hg.mozilla.org/integration/autoland/rev/e1e81b129b5b389f59ccc2144573a7c7af728a2a

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=e0f9c56c15f0f412f2111f1f3379d69b2a213188&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=98306954&repo=autoland

[task 2017-05-11T08:13:01.808829Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/accessible/tests/mochitest/jsat/doc_content_text.html:15:8 | Newline required at end of file but not found. (eol-last)
[task 2017-05-11T08:13:01.808943Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/accessible/tests/mochitest/jsat/test_quicknav_modes.html:107:8 | Newline required at end of file but not found. (eol-last)
[task 2017-05-11T08:13:01.809039Z] TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/accessible/tests/mochitest/jsat/test_tables.html:579:8 | Newline required at end of file but not found. (eol-last)
Flags: needinfo?(standard8)
Assignee

Updated

2 years ago
Flags: needinfo?(standard8)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

2 years ago
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61f9d530898a
Upgrade eslint-plugin-html to 2.0.3 to pick up --fix support. r=jaws

Comment 13

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/61f9d530898a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

Last year
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.