1363014 - Implement browsingData.remove WebExtension API method on android

Status: RESOLVED FIXED

(WebExtensions :: Android, enhancement, P5)

Description

[Tushar Saini (:shatur)]

This method removes the specified browsing data. The doc can be found at [1].

[1]. https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/browsingData/remove

Comment 1

[Tushar Saini (:shatur)]

Attachment: Bug 1363014 - Implement browsingData.remove WebExtension API method on android.

Review commit: https://reviewboard.mozilla.org/r/170058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170058/

Comment 2

[Tushar Saini (:shatur)]

Hey Shane!

Would it be suitable if I resolve the issue you mentioned at [1], here??

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1362998#c15

Comment 3

[Shane Caraveo (:mixedpuppy)]

(In reply to Tushar Saini (:shatur) from comment #2)
> Hey Shane!
> 
> Would it be suitable if I resolve the issue you mentioned at [1], here??
> 
> [1] https://bugzilla.mozilla.org/show_bug.cgi?id=1362998#c15

I'd prefer a followup bug to remove that since schema can handle it.

Comment 4

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8898673 [details]
Bug 1363014 - Implement browsingData.remove WebExtension API method on android.

https://reviewboard.mozilla.org/r/170058/#review178676

This looks good. Nice work, Tushar.

Comment 5

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8898673 [details]
Bug 1363014 - Implement browsingData.remove WebExtension API method on android.

https://reviewboard.mozilla.org/r/170058/#review178966

Comment 6

[Tushar Saini (:shatur)]

Comment on attachment 8898673 [details]
Bug 1363014 - Implement browsingData.remove WebExtension API method on android.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/170058/diff/1-2/

Comment 7

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8898673 [details]
Bug 1363014 - Implement browsingData.remove WebExtension API method on android.

https://reviewboard.mozilla.org/r/170058/#review180164

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/213fe035b50b
Implement browsingData.remove WebExtension API method on android. r=bsilverberg,mixedpuppy,sebastian

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/213fe035b50b