Closed
Bug 1363029
Opened 7 years ago
Closed 7 years ago
nsICryptoHash used off main thread - must be builtinclass
Categories
(Core :: Security: PSM, enhancement)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: mcmanus, Unassigned)
Details
Attachments
(1 file)
the url-classifier uses nsICryptoHash in a worker thread.. that means it can't have a js implementation (you can still use it from js). https://dxr.mozilla.org/mozilla-central/source/toolkit/components/url-classifier/nsUrlClassifierDBService.cpp#963 this patch marks it as a builtinclass to enforce that.
| Comment hidden (mozreview-request) |
|
||
Comment 2•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8865439 [details] Bug 1363029 - mark nsICryptoHash builtinclass https://reviewboard.mozilla.org/r/137112/#review140218 LGTM. I suppose we should audit other PSM interfaces for this sort of thing...
Attachment #8865439 -
Flags: review?(dkeeler) → review+
Pushed by mcmanus@ducksong.com: https://hg.mozilla.org/integration/autoland/rev/1ee4283fc4df mark nsICryptoHash builtinclass r=keeler
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/1ee4283fc4df
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•