1363044 - With --disable-accessibility in mozconfig, "Build failed" / compilation error

Status: UNCONFIRMED

(Firefox Build System :: General, defect)

Description

[xftroxgpx]

Attachment: allows compiling (it's still compiling, I have not reached linking yet)

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/60.0.3093.0 Safari/537.36

Steps to reproduce:

With --disable-accessibility in mozconfig, "Build failed" / compilation error:




Actual results:


19:15.31 /usr/bin/ccache /usr/bin/g++ -std=gnu++11 -o Unified_cpp_dom_cache0.o -c -I/tmp/obj-x86_64-pc-linux-gnu/dist/stl_wrappers -I/tmp/obj-x86_64-pc-linux-gnu/dist/system_wrappers -include /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/dom/cache -I/tmp/obj-x86_64-pc-linux-gnu/dom/cache -I/tmp/obj-x86_64-pc-linux-gnu/ipc/ipdl/_ipdlheaders -I/home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/ipc/chromium/src -I/home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/ipc/glue -I/home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/dom/workers -I/tmp/obj-x86_64-pc-linux-gnu/dist/include  -I/tmp/obj-x86_64-pc-linux-gnu/dist/include/nspr -I/tmp/obj-x86_64-pc-linux-gnu/dist/include/nss    -I/usr/include/pixman-1   -fPIC  -DMOZILLA_CLIENT -include /tmp/obj-x86_64-pc-linux-gnu/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_dom_cache0.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wc++14-compat -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wformat -pipe -march=native -Wno-trigraphs -fno-schedule-insns2 -fno-delete-null-pointer-checks -mtune=native -fomit-frame-pointer -Ofast -fno-fast-math -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe  -freorder-blocks -Os -fomit-frame-pointer  -Wno-error=shadow -fdiagnostics-color  /tmp/obj-x86_64-pc-linux-gnu/dom/cache/Unified_cpp_dom_cache0.cpp
19:16.28 In file included from /tmp/obj-x86_64-pc-linux-gnu/parser/html/Unified_cpp_parser_html0.cpp:20:0:
19:16.28 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp: In static member function ‘static void nsHtml5AttributeName::initializeStatics()’:
19:16.28 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:842:27: error: ‘aria_valuemax’ is not a member of ‘nsGkAtoms’
19:16.28      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_valuemax), ALL_NO_PREFIX);
19:16.28                            ^~~~~~~~~
19:16.28 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:844:27: error: ‘aria_labelledby’ is not a member of ‘nsGkAtoms’
19:16.28      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_labelledby), ALL_NO_PREFIX);
19:16.29                            ^~~~~~~~~
19:16.29 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:846:27: error: ‘aria_describedby’ is not a member of ‘nsGkAtoms’
19:16.29      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_describedby), ALL_NO_PREFIX);
19:16.30                            ^~~~~~~~~
19:16.30 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:848:27: error: ‘aria_disabled’ is not a member of ‘nsGkAtoms’
19:16.30      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_disabled), ALL_NO_PREFIX);
19:16.30                            ^~~~~~~~~
19:16.30 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:850:27: error: ‘aria_checked’ is not a member of ‘nsGkAtoms’
19:16.30      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_checked), ALL_NO_PREFIX);
19:16.31                            ^~~~~~~~~
19:16.31 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:852:27: error: ‘aria_selected’ is not a member of ‘nsGkAtoms’
19:16.31      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_selected), ALL_NO_PREFIX);
19:16.31                            ^~~~~~~~~
19:16.31 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:854:27: error: ‘aria_dropeffect’ is not a member of ‘nsGkAtoms’
19:16.31      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_dropeffect), ALL_NO_PREFIX);
19:16.31                            ^~~~~~~~~
19:16.31 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:856:27: error: ‘aria_required’ is not a member of ‘nsGkAtoms’
19:16.31      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_required), ALL_NO_PREFIX);
19:16.31                            ^~~~~~~~~
19:16.32 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:858:27: error: ‘aria_expanded’ is not a member of ‘nsGkAtoms’
19:16.32      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_expanded), ALL_NO_PREFIX);
19:16.32                            ^~~~~~~~~
19:16.32 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:860:27: error: ‘aria_pressed’ is not a member of ‘nsGkAtoms’
19:16.32      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_pressed), ALL_NO_PREFIX);
19:16.32                            ^~~~~~~~~
19:16.32 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:862:27: error: ‘aria_level’ is not a member of ‘nsGkAtoms’
19:16.32      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_level), ALL_NO_PREFIX);
19:16.32                            ^~~~~~~~~
19:16.32 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:866:27: error: ‘aria_hidden’ is not a member of ‘nsGkAtoms’
19:16.33      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_hidden), ALL_NO_PREFIX);
19:16.33                            ^~~~~~~~~
19:16.34 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:870:27: error: ‘aria_posinset’ is not a member of ‘nsGkAtoms’
19:16.34      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_posinset), ALL_NO_PREFIX);
19:16.35                            ^~~~~~~~~
19:16.35 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:872:27: error: ‘aria_atomic’ is not a member of ‘nsGkAtoms’
19:16.35      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_atomic), ALL_NO_PREFIX);
19:16.36                            ^~~~~~~~~
19:16.36 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:874:27: error: ‘aria_invalid’ is not a member of ‘nsGkAtoms’
19:16.36      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_invalid), ALL_NO_PREFIX);
19:16.36                            ^~~~~~~~~
19:16.37 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:878:27: error: ‘aria_valuemin’ is not a member of ‘nsGkAtoms’
19:16.38      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_valuemin), ALL_NO_PREFIX);
19:16.38                            ^~~~~~~~~
19:16.38 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:880:27: error: ‘aria_multiselectable’ is not a member of ‘nsGkAtoms’
19:16.38      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_multiselectable), ALL_NO_PREFIX);
19:16.38                            ^~~~~~~~~
19:16.38 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:882:27: error: ‘aria_controls’ is not a member of ‘nsGkAtoms’
19:16.38      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_controls), ALL_NO_PREFIX);
19:16.39                            ^~~~~~~~~
19:16.39 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:884:27: error: ‘aria_multiline’ is not a member of ‘nsGkAtoms’
19:16.39      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_multiline), ALL_NO_PREFIX);
19:16.39                            ^~~~~~~~~
19:16.39 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:886:27: error: ‘aria_readonly’ is not a member of ‘nsGkAtoms’
19:16.39      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_readonly), ALL_NO_PREFIX);
19:16.39                            ^~~~~~~~~
19:16.39 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:888:27: error: ‘aria_owns’ is not a member of ‘nsGkAtoms’
19:16.39      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_owns), ALL_NO_PREFIX);
19:16.39                            ^~~~~~~~~
19:16.39 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:890:27: error: ‘aria_activedescendant’ is not a member of ‘nsGkAtoms’
19:16.39      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_activedescendant), ALL_NO_PREFIX);
19:16.40                            ^~~~~~~~~
19:16.40 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:892:27: error: ‘aria_relevant’ is not a member of ‘nsGkAtoms’
19:16.40      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_relevant), ALL_NO_PREFIX);
19:16.40                            ^~~~~~~~~
19:16.40 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:896:27: error: ‘aria_valuenow’ is not a member of ‘nsGkAtoms’
19:16.40      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_valuenow), ALL_NO_PREFIX);
19:16.40                            ^~~~~~~~~
19:16.40 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:898:27: error: ‘aria_sort’ is not a member of ‘nsGkAtoms’
19:16.40      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_sort), ALL_NO_PREFIX);
19:16.40                            ^~~~~~~~~
19:16.40 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:900:27: error: ‘aria_autocomplete’ is not a member of ‘nsGkAtoms’
19:16.41      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_autocomplete), ALL_NO_PREFIX);
19:16.41                            ^~~~~~~~~
19:16.41 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:902:27: error: ‘aria_flowto’ is not a member of ‘nsGkAtoms’
19:16.41      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_flowto), ALL_NO_PREFIX);
19:16.41                            ^~~~~~~~~
19:16.41 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:904:27: error: ‘aria_busy’ is not a member of ‘nsGkAtoms’
19:16.41      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_busy), ALL_NO_PREFIX);
19:16.42                            ^~~~~~~~~
19:16.42 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:906:27: error: ‘aria_live’ is not a member of ‘nsGkAtoms’
19:16.42      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_live), ALL_NO_PREFIX);
19:16.42                            ^~~~~~~~~
19:16.42 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:908:27: error: ‘aria_haspopup’ is not a member of ‘nsGkAtoms’
19:16.42      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_haspopup), ALL_NO_PREFIX);
19:16.43                            ^~~~~~~~~
19:16.44 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5AttributeName.cpp:910:27: error: ‘aria_setsize’ is not a member of ‘nsGkAtoms’
19:16.44      ALL_NO_NS, SAME_LOCAL(nsGkAtoms::aria_setsize), ALL_NO_PREFIX);
19:16.45                            ^~~~~~~~~
19:16.45 In file included from /tmp/obj-x86_64-pc-linux-gnu/parser/html/Unified_cpp_parser_html0.cpp:47:0:
19:16.45 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5ElementName.cpp: In static member function ‘static void nsHtml5ElementName::initializeStatics()’:
19:16.45 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5ElementName.cpp:644:5: error: ‘_switch’ is not a member of ‘nsGkAtoms’
19:16.45      nsGkAtoms::_switch, nsGkAtoms::_switch, nsHtml5TreeBuilder::OTHER);
19:16.45      ^~~~~~~~~
19:16.45 /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/parser/html/nsHtml5ElementName.cpp:644:25: error: ‘_switch’ is not a member of ‘nsGkAtoms’
19:16.45      nsGkAtoms::_switch, nsGkAtoms::_switch, nsHtml5TreeBuilder::OTHER);
19:16.46                          ^~~~~~~~~
19:16.46 make[5]: *** [/home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/config/rules.mk:1063: Unified_cpp_parser_html0.o] Error 1
19:16.46 make[5]: Leaving directory '/tmp/obj-x86_64-pc-linux-gnu/parser/html'
19:16.47 make[4]: *** [/home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/config/recurse.mk:73: parser/html/target] Error 2
19:16.47 make[4]: *** Waiting for unfinished jobs....


Expected results:

compile without errors

Comment 1

[xftroxgpx]

Attachment: mozconfig

me mozconfig

Comment 2

[xftroxgpx]

Linking finished, firefox starts ok, about:addons works, but any other website gives:
"
Gah. Your tab just crashed.
We can help you!

Choose Restore This Tab to reload page content.
"

with this console every time a tab crashes:

[Parent 27230] WARNING: pipe error (81): Connection reset by peer: file /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 353
[Parent 27230] WARNING: pipe error (58): Connection reset by peer: file /home/xftroxgpx/build/1packages/firefox-hg/makepkg_pacman/firefox-hg/src/firefox-hg/ipc/chromium/src/chrome/common/ipc_channel_posix.cc, line 353

###!!! [Parent][MessageChannel] Error: (msgtype=0x2C0081,name=PBrowser::Msg_Destroy) Channel error: cannot send/recv


Therefore either my patch in OP is no good, or something else was introduced. Leaning towards my patch being **** :))
Last working firefox tested was: 356818+.37a5b7f6f101+-1
as per my pacman.log
[2017-05-08 17:21] [ALPM] upgraded firefox-hg (356818+.37a5b7f6f101+-1 -> 357002+.1fda52a1f3b8+-1)

I'll see if I can figure out why is my patch causing this :D

Comment 3

[xftroxgpx]

Forgot to mention that all those aria_* (and _switch) that are failing in OP are in dom/base/nsGkAtomList.h under the #ifdef ACCESSIBILITY

Comment 4

[xftroxgpx]

recompiling without the --disable-accessibility line in mozconfig (and with my patch) => no firefox issues when loading webpages, therefore my patch is no good :)

I'm starting to doubt those aria_* in dom/base/nsGkAtomList.h should actually be under that #ifdef ACCESSIBILITY though.

Comment 5

[xftroxgpx]

Attachment: patch to compile and not crash tabs

I don't know how correct this is but this works so far

Comment 6

[:aceman]

These days it fails even sooner:
WebIDL.WebIDLError: error: Unresolved type '<unresolved scope>::AccessibleNode'., mozilla/obj-x86_64-pc-linux-gnu/dom/bindings/Node.webidl line 217:21
readonly attribute AccessibleNode? accessibleNode;
^
gmake[4]: *** [Makefile:46: webidl.stub] Error 1
gmake[3]: *** [mozilla/config/recurse.mk:101: dom/bindings/export] Error 2

Comment 7

[xftroxgpx]

I'm no longer using the patch from Comment 5 due to the filename no longer existing! But I'm still using ac_add_options --disable-accessibility in mozconfig file without any compilation errors.
Perhaps the other patches that I'm applying, or even better, the other mozconfig settings are having an effect on why I'm not hitting the same compilation error mentioned in Comment 6.

For completion, at the time of writing:

• the list of patches that I'm using are (uncommented) here
• mozconfig is this