Closed Bug 1363057 Opened 3 years ago Closed 3 years ago

make nsIDOMLocation an empty interface

Categories

(Core :: DOM: Core & HTML, enhancement)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file, 2 obsolete files)

location4.patch
32.14 KB, patch
Nika
: review+
Details | Diff | Splinter Review 
This is a follow up of bug 1362003
Depends on: 1362003
Attached patch location4.patch (obsolete) — — Splinter Review
Assignee: nobody → amarchesini
Attachment #8865475 - Flags: review?(bzbarsky)
Comment on attachment 8865475 [details] [diff] [review]
location4.patch

Michael, do you want to review this one?
Attachment #8865475 - Flags: review?(bzbarsky) → review?(michael)
Also, could use a followup to remove nsIDOMLocation altogether.
Attached patch location4.patch (obsolete) — — Splinter Review
Attachment #8865475 - Attachment is obsolete: true
Attachment #8865475 - Flags: review?(michael)
Attachment #8865496 - Flags: review?(bzbarsky)
Attachment #8865496 - Flags: review?(bzbarsky) → review?(michael)
Attached patch location4.patch — — Splinter Review
Attachment #8865496 - Attachment is obsolete: true
Attachment #8865496 - Flags: review?(michael)
Attachment #8865510 - Flags: review?(bzbarsky)
Comment on attachment 8865510 [details] [diff] [review]
location4.patch

Review of attachment 8865510 [details] [diff] [review]:
-----------------------------------------------------------------

r=me - I'm assuming that I was supposed to review this given that bz redirected it to me a couple of times.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
@@ +610,5 @@
>    nsAutoCString locationCStr;
>  
>    if (RefPtr<Location> location = mWindow->Location()) {
>      nsAutoString locationAStr;
> +    res = location->ToString(locationAStr);

Is this change related? Should this be in a separate patch?
Attachment #8865510 - Flags: review?(bzbarsky) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/267ad90533e8
Make nsIDOMLocation an empty interface, r=mystor
Backed out for breaking Windows build like https://treeherder.mozilla.org/logviewer.html#?job_id=97386312&repo=mozilla-inbound
Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac941cae8f63
Make nsIDOMLocation an empty interface, r=mystor
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e25b794d33f0
Backed out changeset 267ad90533e8 for Windows build bustage in nsNativeAppSupportWin.cpp a=backout CLOSED TREE
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69a5f124017d
Fixing tests for nsIDOMLocation removal, r=me
https://hg.mozilla.org/mozilla-central/rev/ac941cae8f63
https://hg.mozilla.org/mozilla-central/rev/69a5f124017d
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.