1363057 - make nsIDOMLocation an empty interface

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

This is a follow up of bug 1362003

Comment 1

[Andrea Marchesini [:baku]]

Attachment: location4.patch

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8865475 [details] [diff] [review]
location4.patch

Michael, do you want to review this one?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Also, could use a followup to remove nsIDOMLocation altogether.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: location4.patch

Comment 5

[Andrea Marchesini [:baku]]

Attachment: location4.patch

Comment 6

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8865510 [details] [diff] [review]
location4.patch

Review of attachment 8865510 [details] [diff] [review]:
-----------------------------------------------------------------

r=me - I'm assuming that I was supposed to review this given that bz redirected it to me a couple of times.

::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
@@ +610,5 @@
>    nsAutoCString locationCStr;
>  
>    if (RefPtr<Location> location = mWindow->Location()) {
>      nsAutoString locationAStr;
> +    res = location->ToString(locationAStr);

Is this change related? Should this be in a separate patch?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/267ad90533e8
Make nsIDOMLocation an empty interface, r=mystor

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for breaking Windows build like https://treeherder.mozilla.org/logviewer.html#?job_id=97386312&repo=mozilla-inbound

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac941cae8f63
Make nsIDOMLocation an empty interface, r=mystor

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e25b794d33f0
Backed out changeset 267ad90533e8 for Windows build bustage in nsNativeAppSupportWin.cpp a=backout CLOSED TREE

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69a5f124017d
Fixing tests for nsIDOMLocation removal, r=me

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ac941cae8f63
https://hg.mozilla.org/mozilla-central/rev/69a5f124017d