Closed
Bug 1363057
Opened 8 years ago
Closed 8 years ago
make nsIDOMLocation an empty interface
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: baku, Assigned: baku)
References
Details
Attachments
(1 file, 2 obsolete files)
32.14 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
This is a follow up of bug 1362003
Assignee | ||
Comment 1•8 years ago
|
||
Assignee: nobody → amarchesini
Attachment #8865475 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•8 years ago
|
||
Comment on attachment 8865475 [details] [diff] [review]
location4.patch
Michael, do you want to review this one?
Attachment #8865475 -
Flags: review?(bzbarsky) → review?(michael)
![]() |
||
Comment 3•8 years ago
|
||
Also, could use a followup to remove nsIDOMLocation altogether.
Assignee | ||
Comment 4•8 years ago
|
||
Attachment #8865475 -
Attachment is obsolete: true
Attachment #8865475 -
Flags: review?(michael)
Attachment #8865496 -
Flags: review?(bzbarsky)
![]() |
||
Updated•8 years ago
|
Attachment #8865496 -
Flags: review?(bzbarsky) → review?(michael)
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #8865496 -
Attachment is obsolete: true
Attachment #8865496 -
Flags: review?(michael)
Attachment #8865510 -
Flags: review?(bzbarsky)
Comment 6•8 years ago
|
||
Comment on attachment 8865510 [details] [diff] [review]
location4.patch
Review of attachment 8865510 [details] [diff] [review]:
-----------------------------------------------------------------
r=me - I'm assuming that I was supposed to review this given that bz redirected it to me a couple of times.
::: media/webrtc/signaling/src/peerconnection/PeerConnectionImpl.cpp
@@ +610,5 @@
> nsAutoCString locationCStr;
>
> if (RefPtr<Location> location = mWindow->Location()) {
> nsAutoString locationAStr;
> + res = location->ToString(locationAStr);
Is this change related? Should this be in a separate patch?
Attachment #8865510 -
Flags: review?(bzbarsky) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/267ad90533e8
Make nsIDOMLocation an empty interface, r=mystor
Backed out for breaking Windows build like https://treeherder.mozilla.org/logviewer.html#?job_id=97386312&repo=mozilla-inbound
Flags: needinfo?(amarchesini)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac941cae8f63
Make nsIDOMLocation an empty interface, r=mystor
Comment 10•8 years ago
|
||
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e25b794d33f0
Backed out changeset 267ad90533e8 for Windows build bustage in nsNativeAppSupportWin.cpp a=backout CLOSED TREE
Comment 11•8 years ago
|
||
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69a5f124017d
Fixing tests for nsIDOMLocation removal, r=me
Comment 12•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ac941cae8f63
https://hg.mozilla.org/mozilla-central/rev/69a5f124017d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•