1363071 - Update PIA (PrivateInternetAccess) logo in SeaMonkey website

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[RickieES aka Ricardo Palomares]

Attachment: binary replacement of the logo, no changes in HTML code

SeaMonkey Project website portrays in its sidebar the logo of PIA (PrivateInternetAccess), which is sponsoring SM project. PIA has recently updated its logo, which should in turn be updated in SM website.

I'm attaching two patches, one which simply replaces the logo, and the other which explicitly declares the width and height of the image.

Looking at the website, it is clear that the sidebar is now widened due to the logo, so perhaps a third patch might be considered with stretched a bit the image.

Comment 1

[RickieES aka Ricardo Palomares]

Attachment: binary replacement of the logo, HTML code changed to add image dimensions

Comment 2

[Frank Wein [:mcsmurf]]

Comment on attachment 8865506 [details] [diff] [review]
binary replacement of the logo, HTML code changed to add image dimensions

Looks fine. I guess it depends on the screen resolution if it stretches the sidebar? Here everything looks fine, the new logo is actually a bit smaller than the old one.

Comment 3

[RickieES aka Ricardo Palomares]

You're right, the navigation sidebar has a percentage width, so it all depends of the viewport width.

Adding cheking-needed keyword.

Comment 4

[Carsten Book [:Tomcat]]

Callek: since this is waiting for about 10 days to checkin, do you know who could do this for the seamokey project ?

Comment 5

[Edmund Wong (:ewong)]

(In reply to Carsten Book [:Tomcat] from comment #4)
> Callek: since this is waiting for about 10 days to checkin, do you know who
> could do this for the seamokey project ?

I can do that.

Thanks Tomcat.

Comment 6

[Carsten Book [:Tomcat]]

thanks ewong for picking this up!

Comment 7

[Carsten Book [:Tomcat]]

setting needinfo to ewong :)

Comment 8

[Frank Wein [:mcsmurf]]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/0d7aa4fa97871fe6b248a8ed95fc3ec7b79f0a95
Bug 1363071 - Update PIA (PrivateInternetAccess) logo in SeaMonkey website, r=mcsmurf

Comment 9

[Frank Wein [:mcsmurf]]

Helped out and pushed the patch :)

Comment 10

[Frank Wein [:mcsmurf]]

Comment on attachment 8865505 [details] [diff] [review]
binary replacement of the logo, no changes in HTML code

Review no longer needed as the other patch has been pushed.

Comment 11

[Edmund Wong (:ewong)]

sorry..  missed this one.  Thanks mcsmurf!

Comment 12

[Edmund Wong (:ewong)]

Comment on attachment 8865506 [details] [diff] [review]
binary replacement of the logo, HTML code changed to add image dimensions

Review of attachment 8865506 [details] [diff] [review]:
-----------------------------------------------------------------

::: lib/sidebar.tmpl
@@ +68,5 @@
>     END;
>  
>     IF template.name == "index.en.html";
>       "<span style=\"font-size: x-small\">Sponsored by:</span><br>\n";
> +     "<a href=\"https://www.privateinternetaccess.com/\"><img src=\"/images/PIALogo1x.png\" width="248" height="38"></a>";

This line is missing some escapes.

width=\"248\" height=\"38\"></a>"

and caused a hiccup in the website scripts.

Comment 13

[Edmund Wong (:ewong)]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/405ce63449a14e8ef61acdfe5021d97453bb8409
Bug 1363071 - Escape quotations fix. r=bustagefix

Comment 14

[Edmund Wong (:ewong)]

Sorry for the proactive bugfix push.  Had to get bug 1369300 fixed asap..

Comment 15

[RickieES aka Ricardo Palomares]

I guess some day I will be able to do something right at first attempt (sigh!)...

Sorry for the mess, and thank you for fixing it so quickly.

Comment 16

[Edmund Wong (:ewong)]

(In reply to [:rickiees] Ricardo Palomares from comment #15)
> I guess some day I will be able to do something right at first attempt
> (sigh!)...
> 
> Sorry for the mess, and thank you for fixing it so quickly.

No worries on that.  I've never done anything on first attempt..