1363074 - When skipping a historyless about:home tab during session restore, we select a replacement even when opening an external tab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Comment 1

[Jan Henning [:JanH]]

Attachment: Bug 1363074 - Part 1 - Clarify meaning of "isExternalURL" variable during session restore.

Review commit: https://reviewboard.mozilla.org/r/137226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137226/

Comment 2

[Jan Henning [:JanH]]

Attachment: Bug 1363074 - Part 2 - When skipping the selected tab during session restore, don't select a replacement if we're also opening an URL from our launch intent.

When starting up, ideally we want to only load the foreground tab, with all other tabs being created as delay-loaded "zombie" tabs that occupy minimal resources. To that extent, when restoring the previous session we need to know whether we're planning to open an additional, external tab for a URL received through the launch intent later on. If we do, we don't want to select any tab while restoring the previous session, as that selection is going to be overridden by the external tab anyway. Not selecting a tab from the previous session at this stage means that it can remain as a delay-loaded tab until it is eventually selected by the user.

Review commit: https://reviewboard.mozilla.org/r/137228/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137228/

Comment 3

[Julian Chu [:walkingice]]

Comment on attachment 8865606 [details]
Bug 1363074 - Part 1 - Clarify meaning of "isExternalURL" variable during session restore.

https://reviewboard.mozilla.org/r/137226/#review140452

Comment 4

[Julian Chu [:walkingice]]

Comment on attachment 8865607 [details]
Bug 1363074 - Part 2 - When skipping the selected tab during session restore, don't select a replacement if we're also opening an URL from our launch intent.

https://reviewboard.mozilla.org/r/137228/#review140454

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88790e87be09
Part 1 - Clarify meaning of "isExternalURL" variable during session restore. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/dc5a4c3ff51c
Part 2 - When skipping the selected tab during session restore, don't select a replacement if we're also opening an URL from our launch intent. r=walkingice

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/88790e87be09
https://hg.mozilla.org/mozilla-central/rev/dc5a4c3ff51c