Closed Bug 1363075 Opened 4 years ago Closed 4 years ago

Stop using the :not(:target) selector in search-arrow-go.svg

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

(Blocks 1 open bug)

Details

(Keywords: perf)

Attachments

(2 files)

As part of fixing bug 1358998 we should stop using the :not(:target) selector in:

https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/search/search-arrow-go.svg
Attached patch patchSplinter Review
Assignee: nobody → jwatt
Attachment #8865515 - Flags: review?(dao+bmo)
Blocks: 1358998
Keywords: perf
Attachment #8865515 - Flags: review?(dao+bmo) → review+
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88bd4874e0bd
Stop using the :not(:target) selector in search-arrow-go.svg. r=dao
https://hg.mozilla.org/mozilla-central/rev/88bd4874e0bd
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1363739
Attached image abouthome.png
This change does not apply to search-arrow-go.svg in complete themes. Complete theme developers cannot modify about:home page (aboutHome.css), but search-arrow-go.svg and search-indicator-magnifying-glass.svg could be. I recommend to move its location to chrome://browser/content, like launcher icons.
You need to log in before you can comment on or make changes to this bug.