Stop using the :not(:target) selector in search-arrow-go.svg

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jwatt, Assigned: jwatt)

Tracking

(Blocks 1 bug, {perf})

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

2 years ago
As part of fixing bug 1358998 we should stop using the :not(:target) selector in:

https://dxr.mozilla.org/mozilla-central/source/browser/themes/shared/search/search-arrow-go.svg
(Assignee)

Comment 1

2 years ago
Posted patch patchSplinter Review
Assignee: nobody → jwatt
Attachment #8865515 - Flags: review?(dao+bmo)
(Assignee)

Updated

2 years ago
Blocks: 1358998
Keywords: perf
Attachment #8865515 - Flags: review?(dao+bmo) → review+

Comment 2

2 years ago
Pushed by jwatt@jwatt.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/88bd4874e0bd
Stop using the :not(:target) selector in search-arrow-go.svg. r=dao

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/88bd4874e0bd
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1363739

Comment 4

2 years ago
Posted image abouthome.png
This change does not apply to search-arrow-go.svg in complete themes. Complete theme developers cannot modify about:home page (aboutHome.css), but search-arrow-go.svg and search-indicator-magnifying-glass.svg could be. I recommend to move its location to chrome://browser/content, like launcher icons.
You need to log in before you can comment on or make changes to this bug.