Closed Bug 1363080 Opened 3 years ago Closed 3 years ago

Ignore /third_party directory when running ESLint

Categories

(Firefox Build System :: Lint and Formatting, enhancement)

3 Branch
enhancement
Not set

Tracking

(firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Third-party is importing from elsewhere, we should just ignore it.
Blocks: 1360166
(In reply to Sylvestre Ledru [:sylvestre] from comment #2)
> You could just ignore all that:
> https://hg.mozilla.org/mozilla-central/file/tip/tools/rewriting/
> ThirdPartyPaths.txt

I just took a look through that. Unfortunately .eslintignore can't directly import it. Looking through the list I would say the vast majority of them (prob >90%) are non-js libraries. At least one of them (hunspell), has a test within the directory which appears to be our own code, and hence should be included.

For now I don't think its worth importing everything, and we should look at it as we enable more directories.
> I just took a look through that. Unfortunately .eslintignore can't directly import it.
Is there anything we could do to make eslint happy ?
(In reply to Sylvestre Ledru [:sylvestre] from comment #4)
> > I just took a look through that. Unfortunately .eslintignore can't directly import it.
> Is there anything we could do to make eslint happy ?

Not without changing the core of ESLint.
Comment on attachment 8865527 [details]
Bug 1363080 - Ignore /third_party directory when running ESLint.

https://reviewboard.mozilla.org/r/137154/#review140594
Attachment #8865527 - Flags: review?(jaws) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aeb03a50c12e
Ignore /third_party directory when running ESLint. r=jaws
https://hg.mozilla.org/mozilla-central/rev/aeb03a50c12e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Testing → Firefox Build System
Version: Version 3 → 3 Branch
You need to log in before you can comment on or make changes to this bug.