Status
()
People
(Reporter: shell, Assigned: Felipe)
Tracking
Firefox Tracking Flags
(firefox54 fixed, firefox55 fixed)
Details
MozReview Requests
()
| Submitter | Diff | Changes | Open Issues | Last Updated |
|---|---|---|---|---|
| Loading... | ||||
| Error loading review requests: | ||||
Attachments
(1 attachment)
|
59 bytes,
text/x-review-board-request
|
mrbkap
:
review+
gchang
:
approval-mozilla-beta+
|
Details | Review |
at this point all the add-ons have ridden in beta without blocklist for several cycles. This is just to remove from blocklist so all add-ons marked MPC=true can get e10s. Our goal is really to not get in between what the authors set unless there is a big issue. Both remaining authors resolved their issues and are OK to set flags without us over-riding in release. mega and tab mix plus are the two.
| Comment hidden (mozreview-request) |
|
||
Comment 2•a year ago
|
||
| mozreview-review | ||
Comment on attachment 8868247 [details] Bug 1363083 - Remove TabMixPlus and Mega from e10s blocklist. https://reviewboard.mozilla.org/r/139826/#review143204
Attachment #8868247 -
Flags: review?(mrbkap) → review+
Pushed by felipc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/c9440363f82f Remove TabMixPlus and Mega from e10s blocklist. r=mrbkap
|
||
Comment 4•a year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c9440363f82f
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
|
(Assignee) | |
Comment 5•a year ago
|
||
Comment on attachment 8868247 [details] Bug 1363083 - Remove TabMixPlus and Mega from e10s blocklist. Approval Request Comment [Feature/Bug causing the regression]: TabMixPlus and Mega have been disqualifying e10s users for a long time, but now their issues with e10s have been fixed, so now users of these 2 addons can be included in the e10s cohorts [User impact if declined]: e10s will continue to be disabled for anyone who have these two addons [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: n/a [Needs manual test from QE? If yes, steps to reproduce]: not for beta, I'll probably get QA done to ship this as a system add-on to the current release (this will be part of a different approval request) [List of other uplifts needed for the feature/fix]: [Is the change risky?]: no [Why is the change risky/not risky?]: well tested code [String changes made/needed]: none
Attachment #8868247 -
Flags: approval-mozilla-beta?
|
||
Updated•a year ago
|
||
status-firefox54: --- → affected
|
|
||
Comment 6•a year ago
|
||
Comment on attachment 8868247 [details] Bug 1363083 - Remove TabMixPlus and Mega from e10s blocklist. Allow users of these 2 addons to be included in the e10s cohorts. Beta54+. Should be in 54 beta 9.
Attachment #8868247 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Comment 7•a year ago
|
||
| bugherderuplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/21648cfdecd8
status-firefox54: affected → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•