1363101 - recent osx opt BBB change turned off new talos perf-reftest job

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

when bug 1358188 landed, the T(p) job failed to be run anymore:
https://treeherder.mozilla.org/#/jobs?repo=autoland&filter-searchStr=osx%20perf-reftest&fromchange=af9a92eb3203ed0f36b7dbb5a64b2af9b25f7f27

I would really like to fix this ASAP or backout since we will be losing coverage, especially when a merge takes place.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1363101.patch

I think this will fix it

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8865558 [details] [diff] [review]
bug1363101.patch

Review of attachment 8865558 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the quick patch!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/431279b0ac7b
recent osx opt BBB change turned off new talos perf-reftest job r=jmaher DONTBUILD

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

do we have a fix for beta?  we are pushing to try with beta sources and unable to get osx jobs running?

Comment 5

[Kim Moir [:kmoir] ET]

The patches from bug 1363101 haven't landed on beta yet, I think this is the issue.  wcosta: are there plans to uplift the patches from bug 1363101 to m-b?

Comment 6

[Greg Arndt [:garndt]]

It looks like comment 5 is referring to this bug.  Are you referring to a patch from another bug?

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

I could be referring to the wrong thing, please help me figure out what is not working for the scenario when pushing beta to try and running osx builds and tests jobs.

Comment 8

[Kim Moir [:kmoir] ET]

Sorry, I meant bug 1358188 in comment 5.  The issue is that jmaher is trying to run talos tests on m-b on try.  However, the changes to schedule the tests + talos via taskcluster have not landed on m-b yet.  This change has been enabled for try.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

I assume this applies to ESR52 as well? I pushed that to Try today and didn't get the requested OSX tests either.

Comment 10

[Wander Lairson Costa]

Do we have link for the try push?

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

this is the try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4aeff94a7fc872e4716def28f89647fd0d0b4488

we manually did a 'add new job' to get the osx tasks running (and the buildbot build)

Comment 12

[Wander Lairson Costa]

(In reply to Joel Maher ( :jmaher) from comment #11)
> this is the try push:
> https://treeherder.mozilla.org/#/
> jobs?repo=try&revision=4aeff94a7fc872e4716def28f89647fd0d0b4488
> 
> we manually did a 'add new job' to get the osx tasks running (and the
> buildbot build)

Something seems outdated, should not have an opt cross compiled build...

Comment 13

[Joel Maher ( :jmaher ) (UTC -8)]

that is a push from beta sources (not trunk/etc.) where the buildbot scheduling stuff has (not) landed?

Comment 14

[Wander Lairson Costa]

(In reply to Joel Maher ( :jmaher) from comment #13)
> that is a push from beta sources (not trunk/etc.) where the buildbot
> scheduling stuff has (not) landed?

I just checked beta and esr52, neither have the patches uplifted. We need uplift patches for bug 1358188 and bug 1350413.

Comment 15

[Greg Arndt [:garndt]]

bug 1362949 probably needs uplifted too

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/431279b0ac7b

Comment 17

[Kim Moir [:kmoir] ET]

verified that this test is not working on th.

Comment 18

[Kim Moir [:kmoir] ET]

last comment should have been *now* working on treeherder

Comment 19

[Wander Lairson Costa]

Will patches for bugs 1358188, 1350413, 1362949 and 1363714 will be uplifted to esr52 and beta?

Comment 20

[Ryan VanderMeulen [:RyanVM]]

I can take a crack at that.

Comment 21

[Joel Maher ( :jmaher ) (UTC -8)]

those look like the right bugs.  beta for sure, I would say esr52 as well.

Comment 22

[Ryan VanderMeulen [:RyanVM]]

Just took a look at this and hit conflicts on the first commit :(. Bug 1350413 rev 971b9548d84c touches taskcluster/taskgraph/morph.py, which only exists on 55+. Looks like there's going to have to be some significant patch reworking here or a lot more uplifts :\

Comment 23

[Wander Lairson Costa]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #22)
> Just took a look at this and hit conflicts on the first commit :(. Bug
> 1350413 rev 971b9548d84c touches taskcluster/taskgraph/morph.py, which only
> exists on 55+. Looks like there's going to have to be some significant patch
> reworking here or a lot more uplifts :\

These are patches I think we need: bug 1333255, bug 1347569, bug 1347889 and bug 1353456. In that order.

Comment 24

[Wander Lairson Costa]

So, after some chat in #taskcluster, best thing is to add new patches to disable the tests that don't apply to beta and esr52, and then uplift everything inside taskcluster/. :jmaher, do you know which tests we should disable in beta and esr52?

Comment 25

[Joel Maher ( :jmaher ) (UTC -8)]

for beta- what new tests are enabled in 55 vs 54
for esr- what new tests are enabled in 55 vs 52

These I don't know, but upon some initial looking I see:
unique to m-c - T(p) T-e10s(p)
unique to beta - runs Wr, M(gl1 gl2 gl3), R(J1 J2 R) W(1 2 3 4 5)  <- NOTE: mostly we are missing non-e10s tests on m-c


for esr-52:
unique to m-c - R(J2) T(*) T-e10s(*) <- no talos on esr, and only 1 jsreftest chunk!!
unique to beta - runs Wr, M(gl1 gl2 gl3), R(J R) W(1 2 3 4 5)  <- NOTE: mostly we are missing non-e10s tests on m-c


I think those are the differences- did we accidentally turn of mochitest-webgl non-e10s on osx opt for trunk?  Same for web-platform-tests?  I honestly don't think we should re-enable them if it was an accident.