1363113 - Set loadinfo.resultPrincipalURI in smileProtocolHandler.is

Status: RESOLVED INVALID

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

From bug 1362461 comment 9:

The right fix is to fix the various comm-central protocol handlers to set resultPrincipalURI on the loadinfo as needed.  See the patches in bug 1319111.  You should be able to find most relevant places by searching for where you set originalURI but not LOAD_REPLACE in protocol handlers.

This is needed since bug 1319111.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug1363113.patch

This should work. I don't know how to test it but I'm sure you know this.

The similar patch from bug 1362461 I was able to test.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8865544 [details] [diff] [review]
Bug1363113.patch

Review of attachment 8865544 [details] [diff] [review]:
-----------------------------------------------------------------

::: chat/components/src/smileProtocolHandler.js
@@ +29,2 @@
>    newChannel: function SPH_newChannel(aURI) {
>      return this.newChannel2(aURI, null);

Maybe we should remove newChannel() since with the 
null.resultPrincipalURI = aURI; in newChannel2() is is *guaranteed* not to work any more.

Comment 3

[Jorg K (CEST = GMT+2)]

Bug 1319111 got backed out now, so nothing to fix here.