Closed
Bug 1363252
Opened 8 years ago
Closed 8 years ago
Increase NS_FLOAT_MANAGER_CACHE_SIZE to 64 in order to reduce the likelihood of dynamic allocations when creating new nsFloatManagers
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Unassigned)
Details
Attachments
(1 file)
No description provided.
|
Reporter | |
Comment 1•8 years ago
|
||
Attachment #8865717 -
Flags: review?(dbaron)
Comment on attachment 8865717 [details] [diff] [review]
Increase NS_FLOAT_MANAGER_CACHE_SIZE to 64 in order to reduce the likelihood of dynamic allocations when creating new nsFloatManagers
r=dbaron, but curious if you tested to see if this helps with the problems you were seeing
Attachment #8865717 -
Flags: review?(dbaron) → review+
|
|
Reporter | |
Comment 3•8 years ago
|
||
(In reply to David Baron :dbaron: ⌚️UTC-7 from comment #2)
> Comment on attachment 8865717 [details] [diff] [review]
> Increase NS_FLOAT_MANAGER_CACHE_SIZE to 64 in order to reduce the likelihood
> of dynamic allocations when creating new nsFloatManagers
>
> r=dbaron, but curious if you tested to see if this helps with the problems
> you were seeing
No, I was seeing malloc from creating nsFloatManagers show up in profiles, and I expect this to improve things. I wrote this patch based on impressions after profiling a few reflow cases...
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7397223d9e39
Increase NS_FLOAT_MANAGER_CACHE_SIZE to 64 in order to reduce the likelihood of dynamic allocations when creating new nsFloatManagers; r=dbaron
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•