1363258 - Factor ConvertStringToNumber/ConvertNumberToString out of HTMLInputElement

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: Bug 1363258 - Part 1: Factor ConvertStringToNumber out of HTMLInputElement.

Review commit: https://reviewboard.mozilla.org/r/137898/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137898/

Comment 2

[Jessica Jong [:jessica] (inactive)]

Attachment: Bug 1363258 - Part 2: Factor ConvertNumberToString out of HTMLInputElement.

Review commit: https://reviewboard.mozilla.org/r/137900/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137900/

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8866276 [details]
Bug 1363258 - Part 1: Factor ConvertStringToNumber out of HTMLInputElement.

https://reviewboard.mozilla.org/r/137898/#review141030

::: dom/html/input/InputType.cpp:224
(Diff revision 1)
> +InputType::ParseDate(const nsAString& aValue, uint32_t* aYear, uint32_t* aMonth,
> +                     uint32_t* aDay) const
> +{
> +  // TODO: move this function and implementation to DateTimeInpuTypeBase when
> +  // refactoring is completed. Now we can only call HTMLInputElement::ParseDate
> +  // from here, since the method is protected and only InpuyType is a friend

InputType

::: dom/html/input/NumericInputTypes.cpp:75
(Diff revision 1)
>    // Value has to be an integral multiple of step.
>    return NS_floorModulo(value - GetStepBase(), step) != mozilla::Decimal(0);
>  }
>  
> +bool
> +NumericInputTypeBase::ConvertStringToNumber(nsAString& aValue,

Took a bit time to figure out this deals with type=range too.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8866277 [details]
Bug 1363258 - Part 2: Factor ConvertNumberToString out of HTMLInputElement.

https://reviewboard.mozilla.org/r/137900/#review141032

::: dom/html/input/InputType.h:84
(Diff revision 1)
> +   * to a date string if type=date or append the number string representing the
> +   * value if type=number.
> +   *
> +   * @param aValue the Decimal to be converted
> +   * @param aResultString [out] the string representing the Decimal
> +   * @return whether the function succeded, it will fail if the current input's

succeeded

Comment 5

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8866276 [details]
Bug 1363258 - Part 1: Factor ConvertStringToNumber out of HTMLInputElement.

https://reviewboard.mozilla.org/r/137898/#review141030

> InputType

Will do, thanks.

> Took a bit time to figure out this deals with type=range too.

Yep, NumericInputTypeBase is inherited by Number and Range.

Comment 6

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8866277 [details]
Bug 1363258 - Part 2: Factor ConvertNumberToString out of HTMLInputElement.

https://reviewboard.mozilla.org/r/137900/#review141032

> succeeded

Will do, thanks.

Comment 7

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8866276 [details]
Bug 1363258 - Part 1: Factor ConvertStringToNumber out of HTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137898/diff/1-2/

Comment 8

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8866277 [details]
Bug 1363258 - Part 2: Factor ConvertNumberToString out of HTMLInputElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/137900/diff/1-2/

Comment 9

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=bf785261be839e1b303b4037fe340938f6b16211&group_state=expanded

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a2dedb04405
Part 1: Factor ConvertStringToNumber out of HTMLInputElement. r=smaug
https://hg.mozilla.org/integration/autoland/rev/d0bb5397ddef
Part 2: Factor ConvertNumberToString out of HTMLInputElement. r=smaug

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6a2dedb04405
https://hg.mozilla.org/mozilla-central/rev/d0bb5397ddef