Closed Bug 1363266 Opened 4 years ago Closed 4 years ago

Avoid busy waiting in safebrowsing gtest test case: SyncApplyUpdates()

Categories

(Toolkit :: Safe Browsing, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: hchang, Assigned: hchang)

References

Details

Attachments

(1 file)

This is in preparation for bug 1359490. SpinEventLoopUntil requires using 
NS_ProcessNextEvent(..., true) so we have to set |done| on the main thread.
Assignee: nobody → hchang
Blocks: 1359490
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #8865757 - Flags: review?(nfroyd)
Hi Nathan,

I've submitted the fix and the try result looks good. Would you like to
have it a review to see if it meets your requirement?

Thanks :)
Comment on attachment 8865757 [details]
Bug 1363266 - Post an event to main thread to set |done| to true.

https://reviewboard.mozilla.org/r/137368/#review140598

Thank you!
Attachment #8865757 - Flags: review?(nfroyd) → review+
Pushed by hchang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dac53c5cc129
Post an event to main thread to set |done| to true. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/dac53c5cc129
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.