1363275 - firefox update dialog box on windows 10 has blurred text

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[stephenranjit]

Attachment: firefox_blurred.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170504105526

Steps to reproduce:

launched firefox.


Actual results:

firefox update started up. the window title "Firefox Update" is clear and readable but the text below it is blurred.
"Firefox is installing your updates and will start in a few moments..."
I thought it was a problem with either my glasses or my display.


Expected results:

the update dialog box should contain clear text throughout

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: screenshot

Comment 2

[Robert Strong (they/them - no direct email)]

Reporter, is there anything unusual about your system that you can think of that may contribute to this?

Comment 3

[Molly Howell (she/her) (mostly inactive)]

I think both of these screenshots are showing improper DPI scaling. Maybe the different looking end results are caused by the behavior changing in the Windows 10 Creators' Update, but I think they would both be fixed if we updated our manifest.

Comment 4

[Molly Howell (she/her) (mostly inactive)]

Attachment: Bug 1363275 - Make the updater progress dialog DPI-aware on Windows.

Review commit: https://reviewboard.mozilla.org/r/137544/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/137544/

Comment 5

[Molly Howell (she/her) (mostly inactive)]

Attachment: DPI-aware screenshot

With the above patch, the dialog now looks like this on my Windows 10.0.15063 system at 200%. Previously it looked like rstrong's screenshot.

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 8865953 [details]
Bug 1363275 - Make the updater progress dialog DPI-aware on Windows.

https://reviewboard.mozilla.org/r/137544/#review140696

Thanks!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6eeb4b1809da
Make the updater progress dialog DPI-aware on Windows. r=rstrong

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6eeb4b1809da