1363279 - Temporary permissions are not cleared when the user submits the url bar

Status: RESOLVED FIXED

(Firefox :: Site Permissions, defect, P3)

Description

[xpeng]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20170302120751

Steps to reproduce:

1.start screen share with getusermedia
2.click the "Don't Allow" button (do not select the "Remember this decision")
could not share screen this time.
3.refresh the link and share screen again , the share list dialog do not pop up and direct to fail to share.


Actual results:

can not share screen anymore .  if we want to share screen we must clear the choice before.


Expected results:

refresh the link to share screen the share list dialog should be popped up again , if we do not select the  "Remember this decision"

Comment 1

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Looks like you're tripping over our new UX. The "Block temporarily" feature (bug 1206232). Forwarding to UX.

Workaround:
 1. Notice the gray square with a slash through it just ahead of the url, next to the (i) page info icon,
 2. Click it or the (i) page info icon to get the page info drop down,
 3. Under permissions, click the (X) next to "Blocked temporarily" twice.
 4. Try again.

Although I thought refreshing the page should do this automatically. Kohei, did you refresh using the ↻ icon or did you hit enter in the url text field?

In fact, I notice in 53 (OSX) that hitting enter does NOT work to clear the block for me. I have to click the ↻ icon. Florian, is this a bug?

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

> did you refresh using the ↻ icon or did you hit enter in the url text field?

Sorry I meant to ask the reporter xpeng that, not Kohei.

Comment 3

[xpeng]

refresh the ↻ icon .  
I restart firefox and share screen again , the share list dialog do not pop up and direct to fail to share.

Comment 4

[Florian Quèze [:florian]]

(In reply to Jan-Ivar Bruaroey [:jib] from comment #1)

> In fact, I notice in 53 (OSX) that hitting enter does NOT work to clear the
> block for me. I have to click the ↻ icon. Florian, is this a bug?

Clearing the temporary block when the user refreshes the page by pressing enter in the location bar seems like a reasonable addition to me (I don't think we implemented that case in bug 1206232).

Comment 5

[Johann Hofmann [:johannh]]

To do this you will need to hook into this function: https://searchfox.org/mozilla-central/rev/99a2a5a955960b0e58ceade1db1f7652d9db4ba1/browser/base/content/urlbarBindings.xml#1528

and do the same stuff that we also do in https://searchfox.org/mozilla-central/rev/99a2a5a955960b0e58ceade1db1f7652d9db4ba1/browser/base/content/tabbrowser.js#3491-3495

However, that's for the old version of the URL bar, which is being rewritten right now. Mark, how can we get the equivalent of handleEnter for QuantumBar?

Thanks!

Comment 6

[Mark Banner (:standard8)]

I guess you could probably add it to https://searchfox.org/mozilla-central/rev/197210b8c139b64f642edaa3336d26b9c1761568/browser/components/urlbar/UrlbarInput.jsm#324 Feels a bit like we should have some sort of event for it, so it could just consume the change, though I'm not sure its totally worth it.

Comment 7

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

People (even within Mozilla) are running into this, being confused by it while trying to figure out how Firefox temporary permissions work.

My understanding of the permission model we're trying to convey to users here is:

1. If reloading is triggered by users (↻ refresh icon or ENTER in URL bar), FF should clear any temporary permissions and temporary blocks.
2. If reloading is caused by the site (window.location = for example), FF should not clear any temporary permissions or temporary blocks.

Fixing this bug seems essential to having a clear and consistent model that users can intuit on their own, since this behavior is not actually documented anywhere.

A P5 where I'm from means "we'll never do this". I'm assuming the URL bar has been fully rewritten at this point. Can we up-prioritize, even fix this now?

Comment 8

[Thomas Nguyen (:tnguyen)]

Personally, I think it would be quite confused for users (I am the one who often enters to URL bar) and this bug should have a higher priority. I think Johannh had a plan for this (he plans to assign a member of his team working on this?).

Comment 9

[Johann Hofmann [:johannh]]

This really shouldn't be difficult but I'm a little overloaded from PTO/leave backlog, maybe Paul (or Thomas?) can take it?

Comment 10

[Paul Zühlcke [:pbz]]

I'll look into this, thanks!

Comment 11

[Paul Zühlcke [:pbz]]

Attachment: Bug 1363279 - Clear temporary permissions if the user reloads a tab via the urlbar. r=johannh

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f5ff9a3a745
Clear temporary permissions if the user reloads a tab via the urlbar. r=johannh

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/1f5ff9a3a745