Add a warning when Console.time(label) is used twice

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Console
VERIFIED FIXED
2 months ago
a month ago

People

(Reporter: baku, Assigned: baku)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
> console.time('a');
a: timer started
>console.time('a'); <-- this is ignored but no warning message is shown.
a: timer started <-- this is a wrong message. timer 'a' already started.

In order to implement this warning message, we need to introduce the check in the DOM Console code.
(Assignee)

Comment 1

2 months ago
Created attachment 8865785 [details] [diff] [review]
console1.patch

Probably I have to fix some tests before landing the patch.
Assignee: nobody → amarchesini
Attachment #8865785 - Flags: review?(bgrinstead)
(Assignee)

Updated

2 months ago
Blocks: 1363307
Comment on attachment 8865785 [details] [diff] [review]
console1.patch

Review of attachment 8865785 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for me from the devtools end
Attachment #8865785 - Flags: review?(bgrinstead) → review+

Comment 3

a month ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5bbcf94d13f
Console.time() prints a warning if used twice with the same label, r=bgrins

Comment 4

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d5bbcf94d13f
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 5

a month ago
I have reproduced this bug with nightly 55.0a1 (2017-05-09) on Ubuntu 16.04(64 Bit).

The bug's fix is now verified on Latest nightly 55.0a1.

Build ID   : 20170513100302
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170512]

Comment 6

a month ago
I have reproduced this bug with Nightly 55.0a1 (2017-05-09) on Windows 10, 64 bit!

The fix is now verified on Latest Nightly

Build ID 	20170523030206
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170524]

Comment 7

a month ago
As per comment 5 and 6 making this bug verified now.
Status: RESOLVED → VERIFIED

Updated

a month ago
status-firefox55: fixed → verified
You need to log in before you can comment on or make changes to this bug.