1363288 - Add a warning when Console.time(label) is used twice

Status: VERIFIED FIXED

(DevTools :: Console, enhancement)

Description

[Andrea Marchesini [:baku]]

> console.time('a');
a: timer started
>console.time('a'); <-- this is ignored but no warning message is shown.
a: timer started <-- this is a wrong message. timer 'a' already started.

In order to implement this warning message, we need to introduce the check in the DOM Console code.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: console1.patch

Probably I have to fix some tests before landing the patch.

Comment 2

[Brian Grinstead [:bgrins]]

Comment on attachment 8865785 [details] [diff] [review]
console1.patch

Review of attachment 8865785 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good for me from the devtools end

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5bbcf94d13f
Console.time() prints a warning if used twice with the same label, r=bgrins

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d5bbcf94d13f

Comment 5

[Md. Majedul islam]

I have reproduced this bug with nightly 55.0a1 (2017-05-09) on Ubuntu 16.04(64 Bit).

The bug's fix is now verified on Latest nightly 55.0a1.

Build ID   : 20170513100302
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0

[testday-20170512]

Comment 6

[Tanvir Rahman]

I have reproduced this bug with Nightly 55.0a1 (2017-05-09) on Windows 10, 64 bit!

The fix is now verified on Latest Nightly

Build ID 	20170523030206
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170524]

Comment 7

[Tanvir Rahman]

As per comment 5 and 6 making this bug verified now.